Woodstox

Remove 'final' modified from Woodstox XMLInputFactory/XMLOutputFactory implementations

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently (as of 3.2.7, 3.9.2) Woodstox seals Stax input and output factory implementations, preventing sub-classing.
This prevents some customizations, such as implementing customized factory instances, without being really required for any specific purpose (individual methods could be made final if and as necessary).
For example, WSTX-168 could possibly be resolved by sub-classing.

Since this is not API or functionality change, I think it should be done both for 4.0 and backported to 3.2.8 as well. The main potential downside, change in class signature (for object serialization) should not matter since factories are not designed to be serializable or used in a way that would require such compatibility.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tatu Saloranta added a comment -

Fixed in 3.2.x branch (for 3.2.8 if released), trunk (pre-4.0).

Show
Tatu Saloranta added a comment - Fixed in 3.2.x branch (for 3.2.8 if released), trunk (pre-4.0).
Hide
Permalink
Tatu Saloranta added a comment -

Included in 3.9.9-1 (released), check fixed in 3.2 branch (for 3.2.8 build).

Show
Tatu Saloranta added a comment - Included in 3.9.9-1 (released), check fixed in 3.2 branch (for 3.2.8 build).

People

  • Assignee:
    Tatu Saloranta
    Reporter:
    Tatu Saloranta
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: