Woodstox

Add support for EBCDIC

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently Woodstox only detects that input appears to be EBCDIC (as per guidance from xml specifications encoding handling), but does not try to handle it but throws a specific exception. This is since it wasn't known whether (a) JDK supports EBCDIC, and/or (b) if anyone really needs support. (b) is no longer true (a user has requested support), and it sounds like JDK does have some level of support. If so, adding EBCDIC handling might be easy to do.

Activity

Hide
Tatu Saloranta added a comment -

Ok, so the magic encoding name in JDK seems to be "cp037"... let's see if I can add support easily.

Show
Tatu Saloranta added a comment - Ok, so the magic encoding name in JDK seems to be "cp037"... let's see if I can add support easily.
Hide
Tatu Saloranta added a comment -

Looks like a relatively simple changes to use cp037, along with minimal auto-detection, works ok with simple sample EBCDIC files I have access to. It is hard to evaluate if that is a proper solution, though, without more extensive test document suite.

At any rate, I'll add support in trunk: could backport this to 3.2 too if necessary.

Show
Tatu Saloranta added a comment - Looks like a relatively simple changes to use cp037, along with minimal auto-detection, works ok with simple sample EBCDIC files I have access to. It is hard to evaluate if that is a proper solution, though, without more extensive test document suite. At any rate, I'll add support in trunk: could backport this to 3.2 too if necessary.
Hide
Tatu Saloranta added a comment -

Added EBCDIC support to trunk, backported to 3.2 branch. Simple baseline unit tests added, seems to work. User that requested feature also did some testing, so I think this can be resolved.

Show
Tatu Saloranta added a comment - Added EBCDIC support to trunk, backported to 3.2 branch. Simple baseline unit tests added, seems to work. User that requested feature also did some testing, so I think this can be resolved.
Hide
Tatu Saloranta added a comment -

Released in 3.2.2, will be part of 4.0. Closing.

Show
Tatu Saloranta added a comment - Released in 3.2.2, will be part of 4.0. Closing.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: