History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: WAGON-148
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Carlos Sanchez
Reporter: pinghe
Votes: 16
Watchers: 18
Operations

If you were logged in you would be able to see more operations.
Maven Wagon

site:deploy (deploying with FTP) Wagon protocol 'ftp' doesn't support directory copying

Created: 18/Nov/05 09:04 PM   Updated: 14/May/08 02:19 AM
Component/s: wagon-ftp
Affects Version/s: 1.0-alpha-4
Fix Version/s: 1.0-beta-3

Time Tracking:
Not Specified

File Attachments: 1. Text File putDirectory-impl.patch (8 kb)
2. Text File putDirectory-impl.patch (6 kb)

Environment: windows
Issue Links:
Duplicate
 


 Description  « Hide
Wagon protocol 'ftp' doesn't support directory copying

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
pinghe - 19/Jan/06 02:16 AM
my pom.xml
<build>
<defaultGoal>install</defaultGoal>
<extensions>
<extension>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-ftp</artifactId>
</extension>
</extensions>
</build>

when exec: mvn site:deploy , error


Frank Cornelis - 16/Oct/06 04:11 AM
I still receive
[INFO] Wagon protocol 'ftp' doesn't support directory copying
when doing a release:perform, even after putting wagon-ftp-1.0-beta-1.jar in the $MAVEN_HOME/lib directory.
In my pom.xml I have to following project/distributionManagement/site/url value:
ftp://www.frankcornelis.be/dcontract/

When will this issue be fixed?


Bose Daggubati - 14/Nov/06 05:52 PM
Is some one working on this issue, Looks like its not yet assigned.
I am trying to deplot the Site, looks like it wants to do a directory FTP and it throws this error.

[INFO] [site:deploy]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Wagon protocol 'ftp' doesn't support directory copying


Mauritz Lovgren - 16/Nov/06 07:24 AM
Same here, are anyone working on this one?
If not, do someone have a good description of using the WEBDAV protocol instead for those that
cannot use SSH due to infrastructure restrictions?

Gregory Block - 28/Nov/06 05:19 PM
Attaching a functioning patch which can be applied to enable FTP upload.

This does a recursive directory upload; all tests pass, and I've used it to upload a site on my side. Should do the job.


Carlos Sanchez - 05/Dec/06 01:08 AM
Comments about your patch:
  • you can't change the API, which means you can't remove public methods
  • don't use tabs
  • don't change format of sources, causes more differencies in patch than intented

See http://maven.apache.org/guides/development/guide-m2-development.html#Maven%20Code%20Style


Gregory Block - 05/Dec/06 11:36 AM
I'll revise patch; as a sidenote, no removal of public API actually took place, it's an add-only patch; it's just the patch noise. I'll review patch in line with your code guidelines and resubmit should you so choose; or feel free to extract only the two new methods should you choose to push early.

Gregory Block - 05/Dec/06 11:46 AM
A cleaner patch than the previous, should be more transparent in terms of the activity and has been reformatted to meet Maven code standards.

Olexandr Zakordonskyy - 30/Mar/07 02:26 AM
When it is going to be fixed? Somebody is working on this issue? It blocks us.

Julien HENRY - 29/Jun/07 05:18 AM
Please release a new version, because the bug is still there in 1.0-beta-2.

Régis Décamps - 07/Aug/07 06:59 AM
As Julien says, the latest version does not fix this issue, and this is blocking deplyment (workaround: do it manually)

Also, the patch contains empty catch blocks (when trying to set the permissions on the FTP server).

In revision 524156 (line 193)
catch ( IOException e )

{ // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }

Maybe the catch should log a warning message?

And I think you can refine the catch block (from http://commons.apache.org/net/apidocs/org/apache/commons/net/ftp/FTPClient.html#completePendingCommand())

catch (FTPConnectionClosedException e)

{ // If the FTP server prematurely closes the connection as a result // of the client being idle or some other reason causing the server // to send FTP reply code 421. This exception may be caught either // as an IOException or independently as itself. }

catch ( IOException e )

{ // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }

Carlos Sanchez - 07/Aug/07 09:17 AM
if you want to get it released please bring it up in the mailing list. This issue has been fixed as indicated in svn

Matthieu Leclercq - 03/Apr/08 10:15 AM
After more that a year, it seems that no new released has been deployed that fixes this issue.
What is the procedure to obtain a working stable release ?