Maven Wagon

LightWeight http wagon not thread-safe

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.1, 2.0
  • Component/s: wagon-http-lightweight
  • Labels:
    None
  • Environment:
    maven 3 with Aether
  • Number of attachments :
    0

Description

Aether (maven3) by default parallelized metadata resolution on 4 threads (aether.metadataResolver.threads) and artifacts downloading on 5 (maven.artifact.threads).
In such context, Wagon is not used sequentially.
LightWeightHttpWagon is designed for mono-thread, sequential usage. It rely on system properties and on setting/resetting java.net.Authenticator singleton.
The result is that, in some cases (typically : when settings defines many repositories with various credentials), credentials may not apply and download will fail

A potential fix is

  • to use Java5 URL.openConnection(Proxy) instead of using system properties
  • to use a shared, singleton java.net.Authenticator that lookup repositories to match the requested URL

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. WAGON-308 Use of proxy properties in lightweight http wagon is not thread-safe

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark Struberg added a comment -

+1 for using URL.openConnection(Proxy)

wagon-2.0 (current trunk) got upgraded to java5 already. So all necessary requirements should be met.

Show
Mark Struberg added a comment - +1 for using URL.openConnection(Proxy) wagon-2.0 (current trunk) got upgraded to java5 already. So all necessary requirements should be met.
Hide
Permalink
nicolas de loof added a comment -

Fixed on 2.x branch, I'll now try to find a workaround on 1.x branch

Show
nicolas de loof added a comment - Fixed on 2.x branch, I'll now try to find a workaround on 1.x branch
Hide
Permalink
nicolas de loof added a comment -

Fixed in 1.x using a class level synchronized block

Show
nicolas de loof added a comment - Fixed in 1.x using a class level synchronized block
Hide
Permalink
Mark Struberg added a comment -

Nicolas, I have not yet looked at the latest source in the 1.x trunk (I'm currently at work), but synchronizing on any wagon class will probably not work. If wagon is used via dependency, then each project will get it's own ClassLoader, thus you could only lock usages in the build, or even in the same mojo invocation (depends on the effective ClassLoader hierarchy). But the proxy is set via System.properties and a singleton_per_OS.

Show
Mark Struberg added a comment - Nicolas, I have not yet looked at the latest source in the 1.x trunk (I'm currently at work), but synchronizing on any wagon class will probably not work. If wagon is used via dependency, then each project will get it's own ClassLoader, thus you could only lock usages in the build, or even in the same mojo invocation (depends on the effective ClassLoader hierarchy). But the proxy is set via System.properties and a singleton_per_OS.
Hide
Permalink
nicolas de loof added a comment -

@Mark you're right, so the only way to get this fixed is to deprecate wagon-http-lightweight and definitively remove it from wagon project as URLConnection can't be used in a concurrent context

Show
nicolas de loof added a comment - @Mark you're right, so the only way to get this fixed is to deprecate wagon-http-lightweight and definitively remove it from wagon project as URLConnection can't be used in a concurrent context

People

  • Assignee:
    Unassigned
    Reporter:
    nicolas de loof
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: