Maven Wagon

Wrong basedir returned for URL without protocol in PathUtils

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-6
  • Fix Version/s: 1.0-beta-7
  • Component/s: wagon-provider-api
  • Labels:
    None
  • Number of attachments :
    0

Description

PathUtils.basedir(String url) currently expects the url to contain the string "://". But this is not always true, see linked issue in the Site Plugin for the full use case. The result is that the returned value is off-by-one in the call substring(). This should be handled gracefully, to allow for urls without a protocol.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MSITE-477 <menu ref="modules"/> href's drop the leading character in the href when staging a site

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Dennis Lundberg added a comment -

Fixed in r944139.

Show
Dennis Lundberg added a comment - Fixed in r944139 .

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Dennis Lundberg
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: