Maven Wagon

HttpClient wagon (wagon-http) uploads all files twice when preemptive authentication is disabled

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-6
  • Fix Version/s: 2.0
  • Component/s: wagon-http
  • Labels:
    None
  • Number of attachments :
    1

Description

This causes timeouts and tends to cause invalid checksums for anything that attaches an observer to the stream or connection (Maven does). It seems that the Sun (lightweight-http) wagon sends the first file twice, then caches the authentication after a challenge and uses preemptive auth from then on. This wagon should probably take steps to approximate this strategy, or possibly even improve on it.

For an example of this, try deploying any artifact to a normal http repository (Nexus uses bare HTTP PUT, for instance) with Maven 2.2.0, and watch the checksums or logs to see how the transfer takes place.

Issue Links

duplicates

Improvement - An improvement or enhancement to an existing feature or task. WAGON-347 Support preemtive authentication

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MNG-4301 Invalid checksums on deploy when using webdav without extension

  • Blocker - Blocks development and/or testing work, production could not run
  • Open - The issue is open and ready for the assignee to start work on it.
is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-4236 [regression] http wagon uploads files twice with Maven 2.2.0 when preemptive auth is disabled (default setting)

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. WAGON-284 Artifacts are uploaded twice in the case of HTTP redirection

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. WAGON-304 Wrong checksum when deploy with wagon:httpclient provider

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tom Fennelly added a comment -

Guys, is there a fix or documented workaround for this issue anywhere? I've been jumping around all of these linked JIRAs without any success.

I've tried using maven 2.2.1 and 3.0.1 and have tried preemptive auth on and off... I've configured both the "httpclient" and "lightweight" wagons in the settings.xml and am still seeing this issue i.e. uploading twice.

Any help would be appreciated.

Show
Tom Fennelly added a comment - Guys, is there a fix or documented workaround for this issue anywhere? I've been jumping around all of these linked JIRAs without any success. I've tried using maven 2.2.1 and 3.0.1 and have tried preemptive auth on and off... I've configured both the "httpclient" and "lightweight" wagons in the settings.xml and am still seeing this issue i.e. uploading twice. Any help would be appreciated.
Hide
Permalink
Chris Tanger added a comment -

For Nexus users this is related to https://issues.sonatype.org/browse/NEXUS-4347

Show
Chris Tanger added a comment - For Nexus users this is related to https://issues.sonatype.org/browse/NEXUS-4347
Hide
Permalink
Jari Aarniala added a comment - - edited

I patched a version of the HTTP wagon for my needs based on the current trunk: https://github.com/codeflows/maven-wagon

You can configure it to use pre-emptive basic auth (with HttpClient 4, based on the example at http://hc.apache.org/httpcomponents-client-ga/tutorial/html/authentication.html) per server like this:

<server>
  <id>your-server-id</id>
  ...
  <configuration>
    <httpConfiguration>
      <usePreemptiveBasicAuth>true</usePreemptiveBasicAuth>
    </httpConfiguration>
  </configuration>
</server>

Can't say if this approach is without its problems, but it seems to work for us (i.e. artifacts are only transferred once.)

This test case sums it up: https://github.com/codeflows/maven-wagon/blob/trunk/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTest.java#L43-52

Show
Jari Aarniala added a comment - - edited I patched a version of the HTTP wagon for my needs based on the current trunk: https://github.com/codeflows/maven-wagon You can configure it to use pre-emptive basic auth (with HttpClient 4, based on the example at http://hc.apache.org/httpcomponents-client-ga/tutorial/html/authentication.html ) per server like this: <server> <id> your-server-id </id> ... <configuration> <httpConfiguration> <usePreemptiveBasicAuth> true </usePreemptiveBasicAuth> </httpConfiguration> </configuration> </server> Can't say if this approach is without its problems, but it seems to work for us (i.e. artifacts are only transferred once.) This test case sums it up: https://github.com/codeflows/maven-wagon/blob/trunk/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTest.java#L43-52
Hide
Permalink
Jari Aarniala added a comment -

Attached patch as well.

Show
Jari Aarniala added a comment - Attached patch as well.

People

  • Assignee:
    Olivier Lamy
    Reporter:
    John Casey
Vote (12)
Watch (11)

Dates

  • Created:
    Updated:
    Resolved: