Maven Wagon

Default the HTTP cookie policy to BROWSER_COMPATIBILITY

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0
  • Component/s: wagon-http
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Kinda related to WAGON-269. Lots of websites these days (even google) are setting Cookies with domains like .google.com
The HTTP commons folks disagree with what all browsers do and allow that to match the google.com domain. I think most folks accept what most browsers do is the right thing even though it goes against what the Cookie RFC says

I think it would behoove us to use the more relaxed BROWSER_COMPATIBILITY mode as the default as that will lower your support questions when wagon is used against domains that do this kind of thing.

Patch of this change attached.

  1. File
    patch
    07/Jul/09 6:39 PM
    1 kB
    Hiram Chirino

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiram Chirino added a comment -

Looks like WAGON-269 tried to fix this issue but it has not. I commented on that issue.

Show
Hiram Chirino added a comment - Looks like WAGON-269 tried to fix this issue but it has not. I commented on that issue.
Hide
Permalink
Brett Porter added a comment -

I'm also noticing that some of the HTTP settings are not sticking Maven due to a bug, so that might be part of the problem.

Show
Brett Porter added a comment - I'm also noticing that some of the HTTP settings are not sticking Maven due to a bug, so that might be part of the problem.
Hide
Permalink
Mark Struberg added a comment -

fixed in r1136083. I implemented this for both commons.httpclient-3.1 and httpcomponents.client-4.1. So both wagon-http and wagon-dav-jackrabbit will use browser compatible cookie policy now.

Show
Mark Struberg added a comment - fixed in r1136083. I implemented this for both commons.httpclient-3.1 and httpcomponents.client-4.1. So both wagon-http and wagon-dav-jackrabbit will use browser compatible cookie policy now.

People

  • Assignee:
    Mark Struberg
    Reporter:
    Hiram Chirino
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: