Maven Wagon

Allow configuration of httpclient to change cookie policy, other options

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-5
  • Fix Version/s: 1.0-beta-6
  • Component/s: wagon-http
  • Labels:
    None
  • Number of attachments :
    0

Description

In some cases, using non-lightweight http wagon can result in WARNING messages about cookies with an incorrect path. This can be a particular problem where internal rewrite modules change the location of a servlet that expects to be at a different path than the one the browser used to access it.

httpclient configuration options need to be exposed for configuration from the settings.xml in order to allow users to fix this. Simply ignoring cookies is probably not a great option, since some sites do rely on session cookies to maintain authentication, etc. Additionally, there is a wealth of configuration available for httpclient, and exposing a method for configuring this wagon comprehensively should help us head off future concerns about one of the other config options.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-4165 http session cookies rejected with non-lightweight http wagon (maybe with lightweight one too)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Casey added a comment -

Fine-grained control now looks like the following:

<server>
  <id>myrepo</id>
  <configuration>
    <httpConfiguration>
      <all>
        <params>
          <http.protocol.cookie-policy>ignoreCookies</http.protocol.cookie-policy>
        </params>
        <useDefaultHeaders>false</useDefaultHeaders>
        <headers>
          <!-- turn off Accept-Encoding from default headers, then re-add the rest of the default headers -->
          <Cache-control>no-cache</Cache-control>
          <Cache-store>no-store</Cache-store>
          <Pragma>no-cache</Pragma>
          <Expires>0</Expires>
        </headers>
      </all>
    </httpConfiguration>
  </configuration>
</server>

Note that you have four configuration sections: all, get, put, and head. These correspond to the HTTP methods used by the http wagon, plus 'all', which supplies configuration for all methods in use.

Show
John Casey added a comment - Fine-grained control now looks like the following: <server> <id> myrepo </id> <configuration> <httpConfiguration> <all> <params> <http.protocol.cookie-policy> ignoreCookies </http.protocol.cookie-policy> </params> <useDefaultHeaders> false </useDefaultHeaders> <headers> <!-- turn off Accept-Encoding from default headers, then re-add the rest of the default headers --> <Cache-control> no-cache </Cache-control> <Cache-store> no-store </Cache-store> <Pragma> no-cache </Pragma> <Expires> 0 </Expires> </headers> </all> </httpConfiguration> </configuration> </server> Note that you have four configuration sections: all, get, put, and head. These correspond to the HTTP methods used by the http wagon, plus 'all', which supplies configuration for all methods in use.
Hide
Permalink
Hiram Chirino added a comment -

I have this in my pom..

    <extensions>
      <extension>
        <groupId>org.apache.maven.wagon</groupId>
        <artifactId>wagon-webdav-jackrabbit</artifactId>
        <version>1.0-beta-6</version>
      </extension>
    </extensions>

And this in my setings xml file...

    <server>
      <id>snapshot.fusesource.org</id>
      <configuration>
        <httpConfiguration>
          <all>
            <params>
              <http.protocol.cookie-policy>compatibility</http.protocol.cookie-policy>
            </params>
          </all>
        </httpConfiguration>
      </configuration>
    </server>

But I still see warnings like this when I deploy:

Feb 21, 2010 6:32:36 PM org.apache.commons.httpclient.HttpMethodBase processCookieHeaders
WARNING: Cookie rejected: "$Version=0; openiona=71.180.152.243.1266795156396940; $Path=/; $Domain=.fusesource.com". Illegal domain attribute ".fusesource.com". Domain of origin: "fusesource.com"
Feb 21, 2010 6:32:36 PM org.apache.commons.httpclient.HttpMethodBase processCookieHeaders
WARNING: Cookie rejected: "$Version=0; openiona=71.180.152.243.1266795156472945; $Path=/; $Domain=.fusesource.com". Illegal domain attribute ".fusesource.com". Domain of origin: "fusesource.com"

I don't think the http.protocol.cookie-policy is actually doing anything. This is kinda related to WAGON-273

Show
Hiram Chirino added a comment - I have this in my pom.. <extensions> <extension> <groupId>org.apache.maven.wagon</groupId> <artifactId>wagon-webdav-jackrabbit</artifactId> <version>1.0-beta-6</version> </extension> </extensions> And this in my setings xml file... <server> <id>snapshot.fusesource.org</id> <configuration> <httpConfiguration> <all> <params> <http.protocol.cookie-policy>compatibility</http.protocol.cookie-policy> </params> </all> </httpConfiguration> </configuration> </server> But I still see warnings like this when I deploy: Feb 21, 2010 6:32:36 PM org.apache.commons.httpclient.HttpMethodBase processCookieHeaders WARNING: Cookie rejected: "$Version=0; openiona=71.180.152.243.1266795156396940; $Path=/; $Domain=.fusesource.com" . Illegal domain attribute ".fusesource.com" . Domain of origin: "fusesource.com" Feb 21, 2010 6:32:36 PM org.apache.commons.httpclient.HttpMethodBase processCookieHeaders WARNING: Cookie rejected: "$Version=0; openiona=71.180.152.243.1266795156472945; $Path=/; $Domain=.fusesource.com" . Illegal domain attribute ".fusesource.com" . Domain of origin: "fusesource.com" I don't think the http.protocol.cookie-policy is actually doing anything. This is kinda related to WAGON-273

People

  • Assignee:
    John Casey
    Reporter:
    John Casey
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: