Maven Wagon
  1. Maven Wagon
  2. WAGON-248

wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-beta-4
    • Fix Version/s: 1.0-beta-5
    • Component/s: wagon-file
    • Labels:
      None
    • Environment:
      windows, linux
    • Testcase included:
      yes
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      When the requested resource has a "/" at the end, it is an indication of directory check.

      The fix is needed to get wagon:list working with file protocol

        Activity

        Hide
        Dan Tran added a comment -

        attached is the patch with test

        Show
        Dan Tran added a comment - attached is the patch with test
        Hide
        Brett Porter added a comment -

        looks good to me, you should go ahead and apply it.

        Does that test apply to other providers as well?

        Show
        Brett Porter added a comment - looks good to me, you should go ahead and apply it. Does that test apply to other providers as well?
        Hide
        Dan Tran added a comment -

        The attached test only applies to wagon-file at this moment.

        In the long term, we should come up with a common test for all providers.

        Show
        Dan Tran added a comment - The attached test only applies to wagon-file at this moment. In the long term, we should come up with a common test for all providers.
        Hide
        Dan Tran added a comment -

        fixed at

        Revision: 724228
        Author: dantran
        Date: 5:22:01 PM, Sunday, December 07, 2008
        Message:
        WAGON-248: wagon-file's FileWagon.resourceExists should check for directory when requested resouce indicate it is a directory


        Modified : /maven/wagon/trunk/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java
        Modified : /maven/wagon/trunk/wagon-providers/wagon-file/src/test/java/org/apache/maven/wagon/providers/file/FileWagonTest.java

        Show
        Dan Tran added a comment - fixed at Revision: 724228 Author: dantran Date: 5:22:01 PM, Sunday, December 07, 2008 Message: WAGON-248 : wagon-file's FileWagon.resourceExists should check for directory when requested resouce indicate it is a directory Modified : /maven/wagon/trunk/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java Modified : /maven/wagon/trunk/wagon-providers/wagon-file/src/test/java/org/apache/maven/wagon/providers/file/FileWagonTest.java

          People

          • Assignee:
            Dan Tran
            Reporter:
            Dan Tran
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: