Deploying to WebDAV repository fails in IAE

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-4
  • Fix Version/s: 1.0-beta-5
  • Component/s: None
  • Labels:
    None
  • Environment:
    Windows XP, Cygwin, Maven 2.1.0-M1
  • Testcase included:
    yes

Description

Under Maven 2.1.0-M1, deploying to a WebDAV repository fails with:

java.lang.IllegalArgumentException: Host name may not be null
        at hidden.org.apache.commons.httpclient.HttpHost.<init>(HttpHost.java:68)
        at hidden.org.apache.commons.httpclient.HttpHost.<init>(HttpHost.java:107)
        at hidden.org.apache.commons.httpclient.HttpMethodBase.setURI(HttpMethodBase.java:280)
        at hidden.org.apache.commons.httpclient.HttpMethodBase.<init>(HttpMethodBase.java:220)
        at hidden.org.apache.commons.httpclient.methods.ExpectContinueMethod.<init>(ExpectContinueMethod.java:93)
        at hidden.org.apache.commons.httpclient.methods.EntityEnclosingMethod.<init>(EntityEnclosingMethod.java:119)
        at hidden.org.apache.jackrabbit.webdav.client.methods.DavMethodBase.<init>(DavMethodBase.java:58)
        at hidden.org.apache.jackrabbit.webdav.client.methods.MkColMethod.<init>(MkColMethod.java:32)
        at org.apache.maven.wagon.providers.webdav.WebDavWagon.doMkCol(WebDavWagon.java:143)
        at org.apache.maven.wagon.providers.webdav.WebDavWagon.mkdirs(WebDavWagon.java:118)
        at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.put(AbstractHttpClientWagon.java:273)
        at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.put(AbstractHttpClientWagon.java:232)
        at org.apache.maven.artifact.manager.DefaultWagonManager.putRemoteFile(DefaultWagonManager.java:263)
        at org.apache.maven.artifact.manager.DefaultWagonManager.putArtifact(DefaultWagonManager.java:172)
        at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy(DefaultArtifactDeployer.java:80)
        at org.apache.maven.plugin.deploy.DeployMojo.execute(DeployMojo.java:173)
        at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:458)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:676)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:538)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:517)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:369)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:330)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:181)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:336)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:129)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:302)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
        at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
        at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
        at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

Run mvn deploy with attached pom.xml. Works under Maven 2.0.9 (albeit with a correct repository URL) but fails under Maven 2.1.0-M1.

  1. XML File
    pom.xml
    25/Sep/08 11:33 AM
    0.8 kB
    Mark Hobson
  2. Text File
    wagon-jackrabbit-webdav.patch
    25/Sep/08 7:11 PM
    0.8 kB
    James William Dumay

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-4043 Resolve or rollback WebDAV wagon deployment issue where hostname is improperly extracted from URL

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Casey added a comment -

Does this issue belong in the WAGON project? It looks on the face of it like the jackrabbit DAV wagon provider isn't setting up the host information correctly...

Show
John Casey added a comment - Does this issue belong in the WAGON project? It looks on the face of it like the jackrabbit DAV wagon provider isn't setting up the host information correctly...
Hide
Permalink
Arnaud Heritier added a comment -

Is it working if you replace <url>dav:http://myhost</url> by <url>http://myhost</url> ??

Show
Arnaud Heritier added a comment - Is it working if you replace <url>dav:http://myhost</url> by <url>http://myhost</url> ??
Hide
Permalink
Mark Hobson added a comment -

Yep, it gets past the IAE if I remove the dav protocol. Is this a new syntax? Feel free to move the issue to a more specific project.

Show
Mark Hobson added a comment - Yep, it gets past the IAE if I remove the dav protocol. Is this a new syntax? Feel free to move the issue to a more specific project.
Hide
Permalink
Brett Porter added a comment -

removing dav: stops using the webdav wagon and uses http. if that works for you, you should use it.

Do you have more information about your environment that could help identify why the IAE is coming out? I can't reproduce.

Show
Brett Porter added a comment - removing dav: stops using the webdav wagon and uses http. if that works for you, you should use it. Do you have more information about your environment that could help identify why the IAE is coming out? I can't reproduce.
Hide
Permalink
James William Dumay added a comment -

Patch fixes a bug where it strips out more slashes than it should.

Ill have a testcase for this shortly.

Show
James William Dumay added a comment - Patch fixes a bug where it strips out more slashes than it should. Ill have a testcase for this shortly.
Hide
Permalink
Benjamin Bentmann added a comment -

James, the usage of replaceAll() in this context looks wrong in general. You seem to intend to cut off the path spec from the URL to get only the host address. Now consider what happens to a URL like http://maven.apache.org/maven when simply the basedir is replaced everywhere (basedir being /maven one ends up with http:/.apache.org), i.e. there is the possibility that the replacement matches in the host part.

Show
Benjamin Bentmann added a comment - James, the usage of replaceAll() in this context looks wrong in general. You seem to intend to cut off the path spec from the URL to get only the host address. Now consider what happens to a URL like http://maven.apache.org/maven when simply the basedir is replaced everywhere (basedir being /maven one ends up with http:/.apache.org), i.e. there is the possibility that the replacement matches in the host part.
Hide
Permalink
John Casey added a comment -

Linked to MNG release process for 2.1.0 final.

Show
John Casey added a comment - Linked to MNG release process for 2.1.0 final.
Hide
Permalink
John Casey added a comment -

For discussion from the mailing list, see: http://www.nabble.com/WebDAV-deploying-bug-with-Maven-2.1.0-M1-to19673500.html#a19680555

Show
John Casey added a comment - For discussion from the mailing list, see: http://www.nabble.com/WebDAV-deploying-bug-with-Maven-2.1.0-M1-to19673500.html#a19680555

People

  • Assignee:
    Brett Porter
    Reporter:
    Mark Hobson
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: