jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven Wagon
  • WAGON-235

LightweightHttpWagon is not using bulletproof URL.openConnexion(Proxy)

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: wagon-http-lightweight
  • Labels:
    None
  • Environment:
    *

Description

LightweightHttpWagon is messing (even in current trunk r68207) with System.setProperty( "http.proxyHost", proxyInfo.getHost() ); in it's openConnectionInternal method.

It's clearly not thread safe and a preferred method would be to use URL.openConnexion(Proxy).

From my point of view, before any call to URL.openConnexion, one should call java.net.ProxySelector#select(URI) and use one (if not every) java.net.Proxy given in the list.
java.net.Proxy handles care for proxy host and port while java.net.ProxySelector is dealing with nonProxyHost and http/https proxy differenciation

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Brett Porter added a comment - 05/Aug/08 5:05 AM

unfortunately that requires JDK 5.0 - currently the min req is 1.4.2

Show
Brett Porter added a comment - 05/Aug/08 5:05 AM unfortunately that requires JDK 5.0 - currently the min req is 1.4.2
Hide
Permalink
Thomas B added a comment - 05/Aug/08 7:17 AM

doesn't fit min req.

Show
Thomas B added a comment - 05/Aug/08 7:17 AM doesn't fit min req.

People

  • Assignee:
    Unassigned
    Reporter:
    Thomas B
Vote (0)
Watch (0)

Dates

  • Created:
    05/Aug/08 4:38 AM
    Updated:
    05/Aug/08 7:17 AM
    Resolved:
    05/Aug/08 7:17 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.