jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven Wagon
  • WAGON-148

site:deploy (deploying with FTP) Wagon protocol 'ftp' doesn't support directory copying

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-alpha-4
  • Fix Version/s: 1.0-beta-3
  • Component/s: wagon-ftp
  • Labels:
    None
  • Environment:
    windows

Description

Wagon protocol 'ftp' doesn't support directory copying

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    putDirectory-impl.patch
    05/Dec/06 11:46 AM
    8 kB
    Gregory Block
  2. Text File
    putDirectory-impl.patch
    28/Nov/06 5:19 PM
    6 kB
    Gregory Block

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. WAGON-35 wagon doesn't support site:deploy via ftp

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. WAGON-78 Support ftp for website deployment

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
pinghe added a comment - 19/Jan/06 2:16 AM

my pom.xml
<build>
<defaultGoal>install</defaultGoal>
<extensions>
<extension>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-ftp</artifactId>
</extension>
</extensions>
</build>

when exec: mvn site:deploy , error

Show
pinghe added a comment - 19/Jan/06 2:16 AM my pom.xml <build> <defaultGoal>install</defaultGoal> <extensions> <extension> <groupId>org.apache.maven.wagon</groupId> <artifactId>wagon-ftp</artifactId> </extension> </extensions> </build> when exec: mvn site:deploy , error
Hide
Permalink
Frank Cornelis added a comment - 16/Oct/06 4:11 AM

I still receive
[INFO] Wagon protocol 'ftp' doesn't support directory copying
when doing a release:perform, even after putting wagon-ftp-1.0-beta-1.jar in the $MAVEN_HOME/lib directory.
In my pom.xml I have to following project/distributionManagement/site/url value:
ftp://www.frankcornelis.be/dcontract/

When will this issue be fixed?

Show
Frank Cornelis added a comment - 16/Oct/06 4:11 AM I still receive [INFO] Wagon protocol 'ftp' doesn't support directory copying when doing a release:perform, even after putting wagon-ftp-1.0-beta-1.jar in the $MAVEN_HOME/lib directory. In my pom.xml I have to following project/distributionManagement/site/url value: ftp://www.frankcornelis.be/dcontract/ When will this issue be fixed?
Hide
Permalink
Bose Daggubati added a comment - 14/Nov/06 5:52 PM

Is some one working on this issue, Looks like its not yet assigned.
I am trying to deplot the Site, looks like it wants to do a directory FTP and it throws this error.

[INFO] [site:deploy]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Wagon protocol 'ftp' doesn't support directory copying

Show
Bose Daggubati added a comment - 14/Nov/06 5:52 PM Is some one working on this issue, Looks like its not yet assigned. I am trying to deplot the Site, looks like it wants to do a directory FTP and it throws this error. [INFO] [site:deploy] [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Wagon protocol 'ftp' doesn't support directory copying
Hide
Permalink
Mauritz Lovgren added a comment - 16/Nov/06 7:24 AM

Same here, are anyone working on this one?
If not, do someone have a good description of using the WEBDAV protocol instead for those that
cannot use SSH due to infrastructure restrictions?

Show
Mauritz Lovgren added a comment - 16/Nov/06 7:24 AM Same here, are anyone working on this one? If not, do someone have a good description of using the WEBDAV protocol instead for those that cannot use SSH due to infrastructure restrictions?
Hide
Permalink
Gregory Block added a comment - 28/Nov/06 5:19 PM

Attaching a functioning patch which can be applied to enable FTP upload.

This does a recursive directory upload; all tests pass, and I've used it to upload a site on my side. Should do the job.

Show
Gregory Block added a comment - 28/Nov/06 5:19 PM Attaching a functioning patch which can be applied to enable FTP upload. This does a recursive directory upload; all tests pass, and I've used it to upload a site on my side. Should do the job.
Hide
Permalink
Carlos Sanchez added a comment - 05/Dec/06 1:08 AM

Comments about your patch:

  • you can't change the API, which means you can't remove public methods
  • don't use tabs
  • don't change format of sources, causes more differencies in patch than intented

See http://maven.apache.org/guides/development/guide-m2-development.html#Maven%20Code%20Style

Show
Carlos Sanchez added a comment - 05/Dec/06 1:08 AM Comments about your patch:
  • you can't change the API, which means you can't remove public methods
  • don't use tabs
  • don't change format of sources, causes more differencies in patch than intented
See http://maven.apache.org/guides/development/guide-m2-development.html#Maven%20Code%20Style
Hide
Permalink
Gregory Block added a comment - 05/Dec/06 11:36 AM

I'll revise patch; as a sidenote, no removal of public API actually took place, it's an add-only patch; it's just the patch noise. I'll review patch in line with your code guidelines and resubmit should you so choose; or feel free to extract only the two new methods should you choose to push early.

Show
Gregory Block added a comment - 05/Dec/06 11:36 AM I'll revise patch; as a sidenote, no removal of public API actually took place, it's an add-only patch; it's just the patch noise. I'll review patch in line with your code guidelines and resubmit should you so choose; or feel free to extract only the two new methods should you choose to push early.
Hide
Permalink
Gregory Block added a comment - 05/Dec/06 11:46 AM

A cleaner patch than the previous, should be more transparent in terms of the activity and has been reformatted to meet Maven code standards.

Show
Gregory Block added a comment - 05/Dec/06 11:46 AM A cleaner patch than the previous, should be more transparent in terms of the activity and has been reformatted to meet Maven code standards.
Hide
Permalink
Olexandr Zakordonskyy added a comment - 30/Mar/07 2:26 AM

When it is going to be fixed? Somebody is working on this issue? It blocks us.

Show
Olexandr Zakordonskyy added a comment - 30/Mar/07 2:26 AM When it is going to be fixed? Somebody is working on this issue? It blocks us.
Hide
Permalink
Julien HENRY added a comment - 29/Jun/07 5:18 AM

Please release a new version, because the bug is still there in 1.0-beta-2.

Show
Julien HENRY added a comment - 29/Jun/07 5:18 AM Please release a new version, because the bug is still there in 1.0-beta-2.
Hide
Permalink
Régis Décamps added a comment - 07/Aug/07 6:59 AM

As Julien says, the latest version does not fix this issue, and this is blocking deplyment (workaround: do it manually)

Also, the patch contains empty catch blocks (when trying to set the permissions on the FTP server).

In revision 524156 (line 193)
catch ( IOException e )

{ // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }

Maybe the catch should log a warning message?

And I think you can refine the catch block (from http://commons.apache.org/net/apidocs/org/apache/commons/net/ftp/FTPClient.html#completePendingCommand())

catch (FTPConnectionClosedException e)

{ // If the FTP server prematurely closes the connection as a result // of the client being idle or some other reason causing the server // to send FTP reply code 421. This exception may be caught either // as an IOException or independently as itself. }

catch ( IOException e )

{ // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }
Show
Régis Décamps added a comment - 07/Aug/07 6:59 AM As Julien says, the latest version does not fix this issue, and this is blocking deplyment (workaround: do it manually) Also, the patch contains empty catch blocks (when trying to set the permissions on the FTP server). In revision 524156 (line 193) catch ( IOException e ) { // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on } Maybe the catch should log a warning message? And I think you can refine the catch block (from http://commons.apache.org/net/apidocs/org/apache/commons/net/ftp/FTPClient.html#completePendingCommand()) catch (FTPConnectionClosedException e) { // If the FTP server prematurely closes the connection as a result // of the client being idle or some other reason causing the server // to send FTP reply code 421. This exception may be caught either // as an IOException or independently as itself. } catch ( IOException e ) { // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }
Hide
Permalink
Carlos Sanchez added a comment - 07/Aug/07 9:17 AM

if you want to get it released please bring it up in the mailing list. This issue has been fixed as indicated in svn

Show
Carlos Sanchez added a comment - 07/Aug/07 9:17 AM if you want to get it released please bring it up in the mailing list. This issue has been fixed as indicated in svn
Hide
Permalink
Matthieu Leclercq added a comment - 03/Apr/08 10:15 AM

After more that a year, it seems that no new released has been deployed that fixes this issue.
What is the procedure to obtain a working stable release ?

Show
Matthieu Leclercq added a comment - 03/Apr/08 10:15 AM After more that a year, it seems that no new released has been deployed that fixes this issue. What is the procedure to obtain a working stable release ?

People

  • Assignee:
    Carlos Sanchez
    Reporter:
    pinghe
Vote (16)
Watch (18)

Dates

  • Created:
    18/Nov/05 9:04 PM
    Updated:
    14/May/08 2:19 AM
    Resolved:
    30/Mar/07 12:48 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.