Maven Wagon

site:deploy (deploying with FTP) Wagon protocol 'ftp' doesn't support directory copying

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-alpha-4
  • Fix Version/s: 1.0-beta-3
  • Component/s: wagon-ftp
  • Labels:
    None
  • Environment:
    windows
  • Number of attachments :
    2

Description

Wagon protocol 'ftp' doesn't support directory copying

Issue Links

Activity

Hide
pinghe added a comment -

my pom.xml
<build>
<defaultGoal>install</defaultGoal>
<extensions>
<extension>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-ftp</artifactId>
</extension>
</extensions>
</build>

when exec: mvn site:deploy , error

Show
pinghe added a comment - my pom.xml <build> <defaultGoal>install</defaultGoal> <extensions> <extension> <groupId>org.apache.maven.wagon</groupId> <artifactId>wagon-ftp</artifactId> </extension> </extensions> </build> when exec: mvn site:deploy , error
Hide
Frank Cornelis added a comment -

I still receive
[INFO] Wagon protocol 'ftp' doesn't support directory copying
when doing a release:perform, even after putting wagon-ftp-1.0-beta-1.jar in the $MAVEN_HOME/lib directory.
In my pom.xml I have to following project/distributionManagement/site/url value:
ftp://www.frankcornelis.be/dcontract/

When will this issue be fixed?

Show
Frank Cornelis added a comment - I still receive [INFO] Wagon protocol 'ftp' doesn't support directory copying when doing a release:perform, even after putting wagon-ftp-1.0-beta-1.jar in the $MAVEN_HOME/lib directory. In my pom.xml I have to following project/distributionManagement/site/url value: ftp://www.frankcornelis.be/dcontract/ When will this issue be fixed?
Hide
Bose Daggubati added a comment -

Is some one working on this issue, Looks like its not yet assigned.
I am trying to deplot the Site, looks like it wants to do a directory FTP and it throws this error.

[INFO] [site:deploy]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Wagon protocol 'ftp' doesn't support directory copying

Show
Bose Daggubati added a comment - Is some one working on this issue, Looks like its not yet assigned. I am trying to deplot the Site, looks like it wants to do a directory FTP and it throws this error. [INFO] [site:deploy] [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Wagon protocol 'ftp' doesn't support directory copying
Hide
Mauritz Lovgren added a comment -

Same here, are anyone working on this one?
If not, do someone have a good description of using the WEBDAV protocol instead for those that
cannot use SSH due to infrastructure restrictions?

Show
Mauritz Lovgren added a comment - Same here, are anyone working on this one? If not, do someone have a good description of using the WEBDAV protocol instead for those that cannot use SSH due to infrastructure restrictions?
Hide
Gregory Block added a comment -

Attaching a functioning patch which can be applied to enable FTP upload.

This does a recursive directory upload; all tests pass, and I've used it to upload a site on my side. Should do the job.

Show
Gregory Block added a comment - Attaching a functioning patch which can be applied to enable FTP upload. This does a recursive directory upload; all tests pass, and I've used it to upload a site on my side. Should do the job.
Hide
Carlos Sanchez added a comment -

Comments about your patch:

  • you can't change the API, which means you can't remove public methods
  • don't use tabs
  • don't change format of sources, causes more differencies in patch than intented

See http://maven.apache.org/guides/development/guide-m2-development.html#Maven%20Code%20Style

Show
Carlos Sanchez added a comment - Comments about your patch:
  • you can't change the API, which means you can't remove public methods
  • don't use tabs
  • don't change format of sources, causes more differencies in patch than intented
See http://maven.apache.org/guides/development/guide-m2-development.html#Maven%20Code%20Style
Hide
Gregory Block added a comment -

I'll revise patch; as a sidenote, no removal of public API actually took place, it's an add-only patch; it's just the patch noise. I'll review patch in line with your code guidelines and resubmit should you so choose; or feel free to extract only the two new methods should you choose to push early.

Show
Gregory Block added a comment - I'll revise patch; as a sidenote, no removal of public API actually took place, it's an add-only patch; it's just the patch noise. I'll review patch in line with your code guidelines and resubmit should you so choose; or feel free to extract only the two new methods should you choose to push early.
Hide
Gregory Block added a comment -

A cleaner patch than the previous, should be more transparent in terms of the activity and has been reformatted to meet Maven code standards.

Show
Gregory Block added a comment - A cleaner patch than the previous, should be more transparent in terms of the activity and has been reformatted to meet Maven code standards.
Hide
Olexandr Zakordonskyy added a comment -

When it is going to be fixed? Somebody is working on this issue? It blocks us.

Show
Olexandr Zakordonskyy added a comment - When it is going to be fixed? Somebody is working on this issue? It blocks us.
Hide
Julien HENRY added a comment -

Please release a new version, because the bug is still there in 1.0-beta-2.

Show
Julien HENRY added a comment - Please release a new version, because the bug is still there in 1.0-beta-2.
Hide
Régis Décamps added a comment -

As Julien says, the latest version does not fix this issue, and this is blocking deplyment (workaround: do it manually)

Also, the patch contains empty catch blocks (when trying to set the permissions on the FTP server).

In revision 524156 (line 193)
catch ( IOException e )

{ // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }

Maybe the catch should log a warning message?

And I think you can refine the catch block (from http://commons.apache.org/net/apidocs/org/apache/commons/net/ftp/FTPClient.html#completePendingCommand())

catch (FTPConnectionClosedException e)

{ // If the FTP server prematurely closes the connection as a result // of the client being idle or some other reason causing the server // to send FTP reply code 421. This exception may be caught either // as an IOException or independently as itself. }

catch ( IOException e )

{ // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }
Show
Régis Décamps added a comment - As Julien says, the latest version does not fix this issue, and this is blocking deplyment (workaround: do it manually) Also, the patch contains empty catch blocks (when trying to set the permissions on the FTP server). In revision 524156 (line 193) catch ( IOException e ) { // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on } Maybe the catch should log a warning message? And I think you can refine the catch block (from http://commons.apache.org/net/apidocs/org/apache/commons/net/ftp/FTPClient.html#completePendingCommand()) catch (FTPConnectionClosedException e) { // If the FTP server prematurely closes the connection as a result // of the client being idle or some other reason causing the server // to send FTP reply code 421. This exception may be caught either // as an IOException or independently as itself. } catch ( IOException e ) { // TODO: handle // michal I am not sure what error means in that context // I think that we will be able to recover or simply we will fail later on }
Hide
Carlos Sanchez added a comment -

if you want to get it released please bring it up in the mailing list. This issue has been fixed as indicated in svn

Show
Carlos Sanchez added a comment - if you want to get it released please bring it up in the mailing list. This issue has been fixed as indicated in svn
Hide
Matthieu Leclercq added a comment -

After more that a year, it seems that no new released has been deployed that fixes this issue.
What is the procedure to obtain a working stable release ?

Show
Matthieu Leclercq added a comment - After more that a year, it seems that no new released has been deployed that fixes this issue. What is the procedure to obtain a working stable release ?

People

Vote (16)
Watch (18)

Dates

  • Created:
    Updated:
    Resolved: