Maven Wagon

The getIfNewer method fails to work if file doesn't exist locally and the Last-Modified header isn't sent by the server

Details

  • Number of attachments :
    0

Description

The code doesn't work correctly if the following two conditions are met simultaneously:

the local file doesn't exist — hence the timestamp parameter is 0
(ii) the remote server doesn't send the "Last-Modified" header.

Since the lastModified variable is initialized to 0 in line 355, if the above two conditions are met,
the following if statement at line 371 evaluates to false:

  • if ( timestamp < lastModified )
    {
    retValue = true;

and therefore the file won't be downloaded, causing the dependency to fail.

This used to work with Maven 1.0.2.

To fix this problem, initialize the lastModified variable to 1.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MAVEN-1659 Dependency jars are not downloading from remote repository placed in Subversion with http access

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. WAGON-90 The getIfNewer method fails to work if file doesn't exist locally when using repo proxy

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lukas Theussl added a comment -

This is a trivial fix and it's causing us MAVEN-1659.

Show
Lukas Theussl added a comment - This is a trivial fix and it's causing us MAVEN-1659 .
Hide
Permalink
Brett Porter added a comment -

I disagree with this fix.

Instead of passing in '0', I think the caller should use get() if the file doesn't exist and getIfNewer() otherwise.

Show
Brett Porter added a comment - I disagree with this fix. Instead of passing in '0', I think the caller should use get() if the file doesn't exist and getIfNewer() otherwise.
Hide
Permalink
Lukas Theussl added a comment -

Please reconsider this. Calling get(String, File) does not solve the issue, actually it will have exactly the same effect, as it only calls get( String, File, long ) with zero timestamp. To really work around the problem one would have to call get( String, File, long ) with a negative timestamp, which is not logical. The timestamp parameter is usually determined by File.lastModified(), which returns zero for files that do not exist, I think wagon should handle this case accordingly.

Show
Lukas Theussl added a comment - Please reconsider this. Calling get(String, File) does not solve the issue, actually it will have exactly the same effect, as it only calls get( String, File, long ) with zero timestamp. To really work around the problem one would have to call get( String, File, long ) with a negative timestamp, which is not logical. The timestamp parameter is usually determined by File.lastModified(), which returns zero for files that do not exist, I think wagon should handle this case accordingly.
Hide
Permalink
Brett Porter added a comment -

good point. fixed by adding an || timestamp == 0 on the check so that will force a download.

Show
Brett Porter added a comment - good point. fixed by adding an || timestamp == 0 on the check so that will force a download.

People

  • Assignee:
    Brett Porter
    Reporter:
    Kohsuke Kawaguchi
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: