Maven Wagon

UNC paths don't work when properly URL encoded.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-2
  • Fix Version/s: 1.0-beta-5
  • Component/s: wagon-file
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Please see http://jira.codehaus.org/browse/MSITE-318 for a summary.

Essentially, it seems that Maven cannot grok URL encoded UNC paths with the file:// scheme.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MNG-4087 Percent encoded characters in file URLs are not decoded upon deployment

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MSITE-318 site:deploy unable to utilize UNC paths

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Task - A task that needs to be done. WAGON-112 Clarify value of basedir property for Repository

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Benjamin Bentmann made changes -
Field Original Value New Value
Link This issue relates to WAGON-112 [ WAGON-112 ]
Benjamin Bentmann made changes -
Link This issue is depended upon by MSITE-318 [ MSITE-318 ]
Brett Porter made changes -
Workflow jira [ 87621 ] Maven New [ 88522 ]
Brett Porter made changes -
Fix Version/s 1.x [ 13408 ]
Hide
Permalink
Benjamin Bentmann added a comment - - edited

Some URL decoding that should help. BTW, I am just guessing that Repository.getBasedir() is intended to return a valid filesystem path for file: URLs. The "fix" for WAGON-112 still doesn't say anything about the precise meaning of this string but all the voodoo in PathUtils.basedir() seems to aim at constructing a local filesystem path....

Show
Benjamin Bentmann added a comment - - edited Some URL decoding that should help. BTW, I am just guessing that Repository.getBasedir() is intended to return a valid filesystem path for file: URLs. The "fix" for WAGON-112 still doesn't say anything about the precise meaning of this string but all the voodoo in PathUtils.basedir() seems to aim at constructing a local filesystem path....
Benjamin Bentmann made changes -
Attachment url-decoding.patch [ 34656 ]
Benjamin Bentmann made changes -
Patch Submitted [Yes]
Testcase included yes
Brett Porter made changes -
Fix Version/s 1.x [ 13408 ]
Fix Version/s 1.0-beta-5 [ 14467 ]
Hide
Permalink
Brett Porter added a comment -

reviewed & applied patch

Show
Brett Porter added a comment - reviewed & applied patch
Brett Porter made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Assignee Brett Porter [ brettporter ]
Benjamin Bentmann made changes -
Link This issue is depended upon by MNG-4087 [ MNG-4087 ]

People

  • Assignee:
    Brett Porter
    Reporter:
    Josh Peters
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: