Validator method can't be found if action method contains MessagesContext

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Not A Bug
  • Affects Version/s: None
  • Fix Version/s: 1.3
  • Component/s: Core
  • Labels:
    None

Description

I have:
register("login",LoginController.class);
register("loginValidator",LoginControllerValidator.class);

public class LoginControllerValidator {
public void forgotPassword(final ErrorsContext errors, final String email) {...}
}

When I don't have MessagesContext in action method validation method is called normally

@PRG(false)
public void forgotPassword(final String email) {...}

If I put MessagesContext in action method validation method is never called

@PRG(false)
public void forgotPassword(final MessagesContext mctx, final String email) {...}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gleb Mazursky added a comment -

hmm, i'm not sure but maybe it has sense in the rare case when validator method needs to output "messages" together with "errors"...

Show
Gleb Mazursky added a comment - hmm, i'm not sure but maybe it has sense in the rare case when validator method needs to output "messages" together with "errors"...
Hide
Permalink
Michael Ward added a comment -

I believe the validator would expect the action method signature to be:

public void forgotPassword(final String email)

Have you tried updating the LoginControllerValidtor method to be:

public void forgotPassword(final ErrorsContext errors, final MessagesContext mctx, final String email)

--Mike

Show
Michael Ward added a comment - I believe the validator would expect the action method signature to be: public void forgotPassword(final String email) Have you tried updating the LoginControllerValidtor method to be: public void forgotPassword(final ErrorsContext errors, final MessagesContext mctx, final String email) --Mike
Hide
Permalink
Gleb Mazursky added a comment -

yes, it's working fine with forgotPassword(final ErrorsContext errors, final MessagesContext mctx, final String email)

I think it does not require fixing

Show
Gleb Mazursky added a comment - yes, it's working fine with forgotPassword(final ErrorsContext errors, final MessagesContext mctx, final String email) I think it does not require fixing

People

  • Assignee:
    Michael Ward
    Reporter:
    Gleb Mazursky
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: