uDIG
  1. uDIG
  2. UDIG-966

Odd effects in hole cutting mode

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: UDIG 1.1.RC3
    • Fix Version/s: UDIG 1.1.x, UDIG 1.2.M6
    • Component/s: tools and editing
    • Labels:
      None
    • Environment:
      WinXP SP2

      Description

      See attached screenshot "HoleCutterProblems.png" for what can happen.
      Some of this may be related to the bug UDIG-965. (Edit outlines and vertices drawn incorrectly.)

      Problems found:
      1. Sometimes all subsequent holes seem to get yellow edit lines to a certain point of an earlier drawn hole after being finished - but the white hole itself is drawn OK - at least for the moment. See "HoleCutterProblems2.png" for an example. I havn't yet found out exactly when this effect happens.

      2. Draw a hole. After finishing it with a double click, do a second double click in the polygon (not in the hole) and then, quickly, a third one. Drawing a second hole will start at the latest location, but double click for finishing this hole will not work. I can often reproduce this at will.

      3. A variation of this: Draw a hole. After double-clicking, quickly click a few times on other locations as if drawing a hole there. Often uDig gets confused and a lot of funny things happen when you try to continue cutting. You get yellow lines drawn somewhere else (HoleCutterProblems3.png) and double-clicking doesn't work any more. In this case press Esc to make uDig work reasonably again.

      Note that while it is easier to preproduce the effects when clicking quickly, I originally encountered them during "normal" editing, i.e. not having done anything wicked.

      Sorry, sending you a movie of it would show the effects mich better, but I hope you can reproduce them anyway.

      1. HoleCutterProblems.png
        3 kB
      2. HoleCutterProblems2.png
        2 kB
      3. HoleCutterProblems3.png
        3 kB
      4. screenshot-1.jpg
        161 kB
      5. screenshot-2.jpg
        165 kB
      6. screenshot-3.jpg
        166 kB

        Activity

        Hide
        Jody Garnett added a comment -
        I have been able to reproduce this problem; leaving it open for the uDig 1.1.0 release.
        Show
        Jody Garnett added a comment - I have been able to reproduce this problem; leaving it open for the uDig 1.1.0 release.
        Hide
        Jody Garnett added a comment -
        bug brought forward to UDIG1.2.M4 visibility
        Show
        Jody Garnett added a comment - bug brought forward to UDIG1.2.M4 visibility
        Hide
        Mauricio Pazos added a comment - - edited
        CODE GRIND SPRINT we could reproduce (not exactly with the same geometry ) the points: 2 and 3 . The issue was resolved. The committed fix allows to continue the edition and finish the hole creation correctly.

        Patch applied at Rev: 31325
        Show
        Mauricio Pazos added a comment - - edited CODE GRIND SPRINT we could reproduce (not exactly with the same geometry ) the points: 2 and 3 . The issue was resolved. The committed fix allows to continue the edition and finish the hole creation correctly. Patch applied at Rev: 31325
        Hide
        John Hudson added a comment -
        The main issue of this bug had been fixed and verified in revision 31335, unfortunately there is now a new issue, a (not so helpful) error message when the User tries:

        1. Cut a hole with only 2 points: see screenshot-1
        2. Cut a hole over another hole: see screenshot-2
        3. Double click finish a hole outside the selected feature: see screenshot-3

        The dialog might be useful if not telling the User an "Internal error has occurred". Possibly change this to me more specific to the invalid hole and possibly undo the last hole they tried to place, as the only way "back" is to undo.
        Show
        John Hudson added a comment - The main issue of this bug had been fixed and verified in revision 31335, unfortunately there is now a new issue, a (not so helpful) error message when the User tries: 1. Cut a hole with only 2 points: see screenshot-1 2. Cut a hole over another hole: see screenshot-2 3. Double click finish a hole outside the selected feature: see screenshot-3 The dialog might be useful if not telling the User an "Internal error has occurred". Possibly change this to me more specific to the invalid hole and possibly undo the last hole they tried to place, as the only way "back" is to undo.
        Hide
        Jesse Eichar added a comment -
        Updated message to be less scary
        Show
        Jesse Eichar added a comment - Updated message to be less scary
        Hide
        John Hudson added a comment -
        I have updated the text for the error message again, to remove the "for data integrity the last edit command was removed" as this was not actually happening.
        Show
        John Hudson added a comment - I have updated the text for the error message again, to remove the "for data integrity the last edit command was removed" as this was not actually happening.

          People

          • Assignee:
            Unassigned
            Reporter:
            Matthias Basler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: