uDIG

Deadlock in EditBlackboardUtil

Details

Description

So, the sequence of actions that leads to the broken map editor functionality:

There is a polygonal layer.
1) I select the "Edit geometry" tool and select any polygon on the layer - vertices are highlighted.
2) Do nothing, just select "Box selection" tool and select features from the layer
3) Press "Delete" button - the dialog is shown, let's choose "Clear" button.
Now only one feature is deleted from the selection and seems everything is broken because of this deadlock...

Commands stop to work, try zoom for example after this...

Issue Links

This issue is depended upon by:
UDIG-740 editblackboard needs to listen to DataStore events Major Analysis

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vitali Diatchkov added a comment -
The deadlock happens in this cycle (the line number is now visible on the screenshot):

                while( dialog != null ) {
                    try{
                            condition.await(500, TimeUnit.MILLISECONDS);
                    }catch(InterruptedException e){
                        return;
                    }
                }

Threads are blocked in turn on the line

condition.await(500, TimeUnit.MILLISECONDS);
Show
Vitali Diatchkov added a comment - The deadlock happens in this cycle (the line number is now visible on the screenshot):                 while( dialog != null ) {                     try{                             condition.await(500, TimeUnit.MILLISECONDS);                     }catch(InterruptedException e){                         return;                     }                 } Threads are blocked in turn on the line condition.await(500, TimeUnit.MILLISECONDS);
Hide
Permalink
Jesse Eichar added a comment -
I tried on my mac and wasn't able to reproduce this. It is a dual core.. I wonder if that is part of the reason. Hmm might be a data problem too (the reason that I can't reproduce). I keep getting a side conflict exception when trying to delete features. I will also try on a different dataset. Unfortunately I have to go home now.

Show
Jesse Eichar added a comment - I tried on my mac and wasn't able to reproduce this. It is a dual core.. I wonder if that is part of the reason. Hmm might be a data problem too (the reason that I can't reproduce). I keep getting a side conflict exception when trying to delete features. I will also try on a different dataset. Unfortunately I have to go home now.
Hide
Permalink
Jesse Eichar added a comment -
yay! I'm able to reproduce the bug.

Working on it now.

Doubt I'll be able finish tonight though. I've commented it out in the code.
Show
Jesse Eichar added a comment - yay! I'm able to reproduce the bug. Working on it now. Doubt I'll be able finish tonight though. I've commented it out in the code.
Hide
Permalink
Jesse Eichar added a comment -
moving this report because the "bad" code is commented out. so we'll revisit the issue later.
Show
Jesse Eichar added a comment - moving this report because the "bad" code is commented out. so we'll revisit the issue later.
Hide
Permalink
Jesse Eichar added a comment -
I have this so it doesn't make a deadlock but the problem is that if an edit event occurs the edit blackboard ignores it, so this has to be addressed later
Show
Jesse Eichar added a comment - I have this so it doesn't make a deadlock but the problem is that if an edit event occurs the edit blackboard ignores it, so this has to be addressed later
Hide
Permalink
Jody Garnett added a comment -
bug brought forward to UDIG1.2.M4 visibility
Show
Jody Garnett added a comment - bug brought forward to UDIG1.2.M4 visibility
Hide
Permalink
John Hudson added a comment -
Cant reproduce the dialog seems to have changed; there is no "Clear" button and the functionality seems not to be the same.
Show
John Hudson added a comment - Cant reproduce the dialog seems to have changed; there is no "Clear" button and the functionality seems not to be the same.
Hide
Permalink
John Hudson added a comment -
I have attached a screen shot.

The functionality seems to work differently, when i select a feature with the box tool it de-selects the feature im currently editing, so when hitting the delete button only the selected feature is deleted not the edited one.
Show
John Hudson added a comment - I have attached a screen shot. The functionality seems to work differently, when i select a feature with the box tool it de-selects the feature im currently editing, so when hitting the delete button only the selected feature is deleted not the edited one.
Hide
Permalink
John Hudson added a comment -
Should have been resolved not closed; please verify.
Show
John Hudson added a comment - Should have been resolved not closed; please verify.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.