uDIG

move vertex display cleanup

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: UDIG 1.1.M8
  • Fix Version/s: UDIG 1.2.M6
  • Component/s: tools and editing
  • Labels:
    None
  • Environment:
    Win 2000, JRE 1.5

Description

After moving the vertex of an existing line, the original line and the moved line are both displayed until a pan or zoom is performed.

Issue Links

This issue is related to:
UDIG-797 "add feature" display refresh Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jesse Eichar added a comment -
Seems simple doesn't it... Unfortunately it is not as simple as it seems. The reason is that in order to get rid of the original you have to either
1. Re-render the entire layer so as not to render that one feature, which can be slow and if you do lots of switching between features this is a useability issue.
2. You can write over the line with a white line. That doesn't completely suck but it is a slight problem as it leaves a white line there instead of the actual feature.

Show
Jesse Eichar added a comment - Seems simple doesn't it... Unfortunately it is not as simple as it seems. The reason is that in order to get rid of the original you have to either 1. Re-render the entire layer so as not to render that one feature, which can be slow and if you do lots of switching between features this is a useability issue. 2. You can write over the line with a white line. That doesn't completely suck but it is a slight problem as it leaves a white line there instead of the actual feature.
Hide
Permalink
Michael Brasser added a comment -
Can we use (1), but specify an update region so the entire layer isn't re-rendered? For example, is there a way to use ILayer's refresh() function with the parameter being the intersection of the bounds of the original postion and the new position?
Show
Michael Brasser added a comment - Can we use (1), but specify an update region so the entire layer isn't re-rendered? For example, is there a way to use ILayer's refresh() function with the parameter being the intersection of the bounds of the original postion and the new position?
Hide
Permalink
Michael Brasser added a comment -
OK, I've tried to implement (1), partly just to get a better feel for how things work.

The fix sort of works -- the first time I move a vertex it doesn't work, and then every time after that it works fine (?). There is a bit of lag, but not enough to affect my work. But then again, I'm working with a pretty small data set.

I've attached the code changes if you are interested in trying it out (I'd also love to hear any suggestions you might have).
 
Show
Michael Brasser added a comment - OK, I've tried to implement (1), partly just to get a better feel for how things work. The fix sort of works -- the first time I move a vertex it doesn't work, and then every time after that it works fine (?). There is a bit of lag, but not enough to affect my work. But then again, I'm working with a pretty small data set. I've attached the code changes if you are interested in trying it out (I'd also love to hear any suggestions you might have).  
Hide
Permalink
Jesse Eichar added a comment -
What I worry about with this fix is what happens when the line crosses the entire display. Could be pretty painful. I think I'll make this a preference that is off by default, but you can set it to on by having a startup extension that starts it. I'll give you a code snippet when I add it.
Show
Jesse Eichar added a comment - What I worry about with this fix is what happens when the line crosses the entire display. Could be pretty painful. I think I'll make this a preference that is off by default, but you can set it to on by having a startup extension that starts it. I'll give you a code snippet when I add it.
Hide
Permalink
Jesse Eichar added a comment -
I don't think this is the way to go about fixing this bug. In one of the first versions of uDig we actually did our editing in a very similar manner and it became quite annoying. What I'm proposing is to re-render the area when a feature is selected so that the selected feature is not rendered.

That phrase is probably confusing but...sorry, I don't know if I can make it more clear. I'll have the fix in by friday. Basically what it means is that when features are selected, area contained by those features are re-rendered but the selected features aren't. Only the simplified "edit" drawing is drawn in place for those features. It will still have to be a preference or at least easily disabled so that for apps that don't want it can have it off.
Show
Jesse Eichar added a comment - I don't think this is the way to go about fixing this bug. In one of the first versions of uDig we actually did our editing in a very similar manner and it became quite annoying. What I'm proposing is to re-render the area when a feature is selected so that the selected feature is not rendered. That phrase is probably confusing but...sorry, I don't know if I can make it more clear. I'll have the fix in by friday. Basically what it means is that when features are selected, area contained by those features are re-rendered but the selected features aren't. Only the simplified "edit" drawing is drawn in place for those features. It will still have to be a preference or at least easily disabled so that for apps that don't want it can have it off.
Hide
Permalink
Michael Brasser added a comment -
I think I understand what you mean. What will happen when the selection is "finished"? For example:

1. User selects feature 'F1' (and F1 "disappears", with "edit" drawing in its place)
2. User moves F1 to new location ("edit" drawing shows new position)
3. User selects feature 'F2'

At (3), will F1 be rerendered in its new location? I am assuming once F2 is selected, the "edit" drawing for F1 will disappear?
Show
Michael Brasser added a comment - I think I understand what you mean. What will happen when the selection is "finished"? For example: 1. User selects feature 'F1' (and F1 "disappears", with "edit" drawing in its place) 2. User moves F1 to new location ("edit" drawing shows new position) 3. User selects feature 'F2' At (3), will F1 be rerendered in its new location? I am assuming once F2 is selected, the "edit" drawing for F1 will disappear?
Hide
Permalink
Jody Garnett added a comment -
bug brought forward to UDIG1.2.M4 visibility
Show
Jody Garnett added a comment - bug brought forward to UDIG1.2.M4 visibility

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.