Issue Details (XML | Word | Printable)

Key: UDIG-352
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Jody Garnett
Reporter: Richard Gould
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
uDIG

CatalogTreeViewer.getChildren calls IResolve.members in the UI thread

Created: 17/Mar/05 03:24 PM   Updated: 20/May/05 03:22 PM
Component/s: catalog, metadata and search
Affects Version/s: UDIG 0.9
Fix Version/s: UDIG 0.9


 Description  « Hide
Members is a blocking method and should not be called in the UI thread.

public Object[] getChildren(Object parent) {

if(parent == null)
return null;
if( parent instanceof List)
return ((List)parent).toArray();
if( parent instanceof String )
return new Object[0];
if( parent instanceof IResolve )
try { return ((IResolve)parent ).members(null).toArray(); } catch (IOException e) { CorePlugin.log(CatalogUIPlugin.getDefault(), e); }

return null;
}



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
David Zwiers added a comment - 17/Mar/05 03:32 PM
Not mine.

Richard Gould added a comment - 17/Mar/05 03:45 PM
Perhaps jody can tackle this?

Jody Garnett added a comment - 20/Mar/05 09:33 PM
Call to members now run in a separate thread, note: Search and Wizard make use of ResolveTreeViewerSimple with ResolveTitleDecorator. These both abuse the fact that their results are already resolved.