uDIG

Editing Add Vertex is not undoable

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: UDIG 1.3.0
  • Fix Version/s: None
  • Component/s: tools and editing
  • Labels:
    None

Description

As per walkthrough 2:
1. select a road in tasmania
2. Move it around a lake
3. Add a couple vertices.
4. Press Undo and Redo

The move vertex commands work; the add vertex commands are not "undone" resulting in further confusion when they are applied again via "redo".

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
The log showed the following - but it is suspect as the state of the command stack may already of been corrupted:

!MESSAGE [Snap To Vertex Command] failed to run
!STACK 0
java.lang.NullPointerException: No points associated with (301,185)
at net.refractions.udig.tools.edit.support.EditBlackboard.setCoords(EditBlackboard.java:1286)
at net.refractions.udig.tools.edit.commands.MoveVertexCommand.run(MoveVertexCommand.java:82)
at net.refractions.udig.project.command.UndoableComposite.execute(UndoableComposite.java:81)
at net.refractions.udig.project.command.CommandManager$Executor.execute(CommandManager.java:394)
at net.refractions.udig.project.command.CommandManager$Executor.run(CommandManager.java:325)
at net.refractions.udig.project.command.CommandManager$Executor.run(CommandManager.java:311)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Show
Jody Garnett added a comment - The log showed the following - but it is suspect as the state of the command stack may already of been corrupted: !MESSAGE [Snap To Vertex Command] failed to run !STACK 0 java.lang.NullPointerException: No points associated with (301,185) at net.refractions.udig.tools.edit.support.EditBlackboard.setCoords(EditBlackboard.java:1286) at net.refractions.udig.tools.edit.commands.MoveVertexCommand.run(MoveVertexCommand.java:82) at net.refractions.udig.project.command.UndoableComposite.execute(UndoableComposite.java:81) at net.refractions.udig.project.command.CommandManager$Executor.execute(CommandManager.java:394) at net.refractions.udig.project.command.CommandManager$Executor.run(CommandManager.java:325) at net.refractions.udig.project.command.CommandManager$Executor.run(CommandManager.java:311) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Hide
Permalink
Jody Garnett added a comment -
Okay so the command is actually InsertOnNearestEdgeCommand.

It eventually (and carefully) calls EditBlackboard:

            this.edges=board.addToNearestEdge(toAdd.getX(), toAdd.getY(),polygonLayer);

When we rollback we also delegate to EditBlackboard:

            board.removeCoordinate(edge.getIndexOfPrevious()+1, edge.getAddedCoord(), edge.getPart());

An initial run through with the debugger does not indicate anything obviously wrong; the data structure appears to be updated. However when the map is redrawn the vertex is still present and can still be moved.
Show
Jody Garnett added a comment - Okay so the command is actually InsertOnNearestEdgeCommand. It eventually (and carefully) calls EditBlackboard:             this.edges=board.addToNearestEdge(toAdd.getX(), toAdd.getY(),polygonLayer); When we rollback we also delegate to EditBlackboard:             board.removeCoordinate(edge.getIndexOfPrevious()+1, edge.getAddedCoord(), edge.getPart()); An initial run through with the debugger does not indicate anything obviously wrong; the data structure appears to be updated. However when the map is redrawn the vertex is still present and can still be moved.
Hide
Permalink
Jody Garnett added a comment -
This actually seems to be a general problem editing / panic - the shape and edit geom are getting inconsistent even with just using the edit tool to move vertexes around.
Show
Jody Garnett added a comment - This actually seems to be a general problem editing / panic - the shape and edit geom are getting inconsistent even with just using the edit tool to move vertexes around.

People

  • Assignee:
    Unassigned
    Reporter:
    Jody Garnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: