uDIG

Label style not applying

Details

  • Type: Bug Bug
  • Status: In Progress In Progress
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: UDIG 1.2.2
  • Fix Version/s: None
  • Component/s: visualization using map layer and style
  • Labels:
    None
  • Environment:
    Apple OS X 10.7

Description

The "enable/disable labels" checkbox in style dialog wont apply changes if they are made before the "enable/disable labels" check box is checked.

After further investigation it looks like this happens on all the style dialog tabs.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Levi Putna added a comment -
The simple fix is to disable these fields when the combo is not checked, I think it is a eclipse UI guideline to disable fields that you cant edit anyway.

Can anyone see an issue with this?
Show
Levi Putna added a comment - The simple fix is to disable these fields when the combo is not checked, I think it is a eclipse UI guideline to disable fields that you cant edit anyway. Can anyone see an issue with this?
Hide
Permalink
Andrea Antonello added a comment -
Yep, your idea looks good to me, thanks. I made the change, since I had some raster style additions to do.
Can you check if it works?
Show
Andrea Antonello added a comment - Yep, your idea looks good to me, thanks. I made the change, since I had some raster style additions to do. Can you check if it works?
Hide
Permalink
Levi Putna added a comment -
Thanks Andrea,

You fix works perfectly for Labels.

I noticed this same or similar issue also appears in the both the border and fill tabs. Example, if you disable border then change the color the layer will still render with a border even with "enable/disable border" unchecked.

I think the border and fill tabs could also benefit from having these fields disabled when the enable/disable checkbox is not checked.

Just a thought, Great work.
Show
Levi Putna added a comment - Thanks Andrea, You fix works perfectly for Labels. I noticed this same or similar issue also appears in the both the border and fill tabs. Example, if you disable border then change the color the layer will still render with a border even with "enable/disable border" unchecked. I think the border and fill tabs could also benefit from having these fields disabled when the enable/disable checkbox is not checked. Just a thought, Great work.
Hide
Permalink
Andrea Antonello added a comment -
Hah, you are so right! I will leave this JIra open to remember it, but I won't have time to do that today. If you are in urgent need, let me know.
Thanks
Show
Andrea Antonello added a comment - Hah, you are so right! I will leave this JIra open to remember it, but I won't have time to do that today. If you are in urgent need, let me know. Thanks
Hide
Permalink
Levi Putna added a comment -
No urgent need, I was just digging around uDig familiarising myself with the code and I came across it.
Show
Levi Putna added a comment - No urgent need, I was just digging around uDig familiarising myself with the code and I came across it.
Hide
Permalink
Andrea Antonello added a comment -
Nice!
Feel free to make any enhancements while you stroll throught the code! :)
Show
Andrea Antonello added a comment - Nice! Feel free to make any enhancements while you stroll throught the code! :)

People

  • Assignee:
    Andrea Antonello
    Reporter:
    Levi Putna
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: