uDIG
  1. uDIG
  2. UDIG-1757

UI Plugin ImageDescriptor initialized in wrong "phase"

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: UDIG 1.2.0, UDIG 1.2.1
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None

      Description

      Some UI Plugins (AbstractUIPlugin's) initialize Images/ImageRegistry on Bundle create() methods and uses PlatformGIS.syncInDisplayThread() .
      It should be initialized by overwrite AbtractUIPlugin.initializeImageRegistry(ImageRegistry reg) when a registry is already created.

      Additional the Images class should only be a helper class to load Images from a specified folder. All duplicates should be removed. All calling classes should use

      PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.<global_id>);

      or <AbtractUIPlugin>.getImageRegistry().get()

      to get an Image
      or even getImageDescriptor to get the Descriptor.

      The ImageRegistry is a lazy load Cache like the uDig Images class but core eclipse.

        Activity

        Hide
        Frank Gasdorf added a comment -
        Andrea merged the pull request to the master branch. Thanks for that! Could we merge this to the 1.2.x branch too?
        Show
        Frank Gasdorf added a comment - Andrea merged the pull request to the master branch. Thanks for that! Could we merge this to the 1.2.x branch too?

          People

          • Assignee:
            Jody Garnett
            Reporter:
            Frank Gasdorf
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: