Details
-
Type:
Bug
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: UDIG 1.2.M7
-
Fix Version/s: None
-
Component/s: catalog, metadata and search
-
Labels:None
Description
if (adaptee.isAssignableFrom(ActiveMemoryDataStore.class)) { return adaptee.cast(getDS()); }
.... should be...
if (ActiveMemoryDataStore.class.isAssignableFrom(adaptee)) { return adaptee.cast(getDS()); }
... because adaptee usually extends ActiveMemoryDataStore.
I am expecting adaptee to be "DataStore.class" 90% of the time
DataStore is assignable from ActiveMemoryDataStore .. perfect?
DataStore ds = (ActiveMemoryDataStore) activeMemoryDataStore; // perfect
ActiveMemoryDataStore ds = (ActiveMemoryDataStore) activeMemoryDataStore; // also works
The other way around. ActiveMemoryDataStore.class is assignable from DataStore? nope that does not work....
ActiveMemoryDataStore victim = (DataStore) ds; // invalid