[#UDIG-1688] MemoryServiceImpl resolve assignableFrom error - jira.codehaus.org

Details

Type: Bug
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: UDIG 1.2.M7
Fix Version/s: None
Component/s: catalog, metadata and search
Labels:
None

Description

 if (adaptee.isAssignableFrom(ActiveMemoryDataStore.class)) {
            return adaptee.cast(getDS());
 }

.... should be...

 if (ActiveMemoryDataStore.class.isAssignableFrom(adaptee)) {
            return adaptee.cast(getDS());
 }

... because adaptee usually extends ActiveMemoryDataStore.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Jody Garnett added a comment - 07/Jul/10 11:48 AM

I always get these confused... okay from the top.

I am expecting adaptee to be "DataStore.class" 90% of the time

DataStore is assignable from ActiveMemoryDataStore .. perfect?

DataStore ds = (ActiveMemoryDataStore) activeMemoryDataStore; // perfect
ActiveMemoryDataStore ds = (ActiveMemoryDataStore) activeMemoryDataStore; // also works

The other way around. ActiveMemoryDataStore.class is assignable from DataStore? nope that does not work....

ActiveMemoryDataStore victim = (DataStore) ds; // invalid

Show

Jody Garnett added a comment - 07/Jul/10 11:48 AM I always get these confused... okay from the top. I am expecting adaptee to be "DataStore.class" 90% of the time DataStore is assignable from ActiveMemoryDataStore .. perfect? DataStore ds = (ActiveMemoryDataStore) activeMemoryDataStore; // perfect ActiveMemoryDataStore ds = (ActiveMemoryDataStore) activeMemoryDataStore; // also works The other way around. ActiveMemoryDataStore.class is assignable from DataStore? nope that does not work.... ActiveMemoryDataStore victim = (DataStore) ds; // invalid

Hide

Permalink

Jens Rummler added a comment - 08/Jul/10 2:23 AM - edited

Same with me... Ok, this is my use-case:

I have a class extending ActiveMemoryDataStore

public class FooMemoryDataStore extends ActiveMemoryDataStore

... and a factory:
public class FooMemoryDSFactory implements MemoryDSFactory {

When I try to use it (ok, yes, I'm extending MemoryServiceImp ;-) ) I call:
FooMemoryDataStore routingMemoryDataStore = (FooMemoryDataStore) this.resolve(FooMemoryDataStore.class, new NullProgressMonitor()); //not working

My workaround is:
FooMemoryDataStore fooMemoryDataStore = (FooMemoryDataStore) this.resolve(ActiveMemoryDataStore.class, new NullProgressMonitor()); //working

What about
if (DataStore.class.isAssignableFrom(adaptee)) //???

Show

Jens Rummler added a comment - 08/Jul/10 2:23 AM - edited Same with me... Ok, this is my use-case: I have a class extending ActiveMemoryDataStore public class FooMemoryDataStore extends ActiveMemoryDataStore ... and a factory: public class FooMemoryDSFactory implements MemoryDSFactory { When I try to use it (ok, yes, I'm extending MemoryServiceImp ;-) ) I call: FooMemoryDataStore routingMemoryDataStore = (FooMemoryDataStore) this.resolve(FooMemoryDataStore.class, new NullProgressMonitor()); //not working My workaround is: FooMemoryDataStore fooMemoryDataStore = (FooMemoryDataStore) this.resolve(ActiveMemoryDataStore.class, new NullProgressMonitor()); //working What about if (DataStore.class.isAssignableFrom(adaptee)) //???

MemoryServiceImpl resolve assignableFrom error

Details

Description

Activity

People

Dates