uDIG

Tools are deactivated after restarting udig.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: UDIG 1.2.RC3
  • Fix Version/s: UDIG 1.2.2
  • Component/s: tools and editing
  • Labels:
    None
  • Environment:
    kubuntu 9.10 x86, java 1.6, udig 1.2-rc4

Description

It happens on udig 1.2-rc4.

After restarting uDig all the tools are deactivated.

To produce this error do the next steps:

-Create a new map with a polygon layer.
-Draw a feature and save the layer.
-Close uDig and launch again.
-Take a look at the tools and you will see all of then are deactivated.

It seems that this error is because all the tools can't activated. Take a look which condition on the activations is preventing the tool to activate (for example, the tool could look if the layer has a geometry and the layer return it hasn't a geometry, even if it really has, but the tool receives a false so it won't active.)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mauricio Pazos added a comment -
It requires a code review of:
ShowViewInterceptor Lines 121-130

FeatureStoreResourceProperty lines 63-67


Show
Mauricio Pazos added a comment - It requires a code review of: ShowViewInterceptor Lines 121-130 FeatureStoreResourceProperty lines 63-67
Hide
Permalink
Mauricio Pazos added a comment -
Committed revision 31866.
Show
Mauricio Pazos added a comment - Committed revision 31866.
Hide
Permalink
Jody Garnett added a comment -
Reviewed; patch committed making the code a bit more safe. Test case still needs to be corrected.
Show
Jody Garnett added a comment - Reviewed; patch committed making the code a bit more safe. Test case still needs to be corrected.
Hide
Permalink
Mauricio Pazos added a comment - - edited
Unfortunately, I have realized we have not resolved the bug.

The first time, when the layer is created, the ShowViewInterceptor.run method receives an UDIGFeatureStore, it is ok, because the tools can ediit it (the tools are available).

But, if you close udig and reopen it, the same layer has a DefaultQuery. DefaultQuere is not a DataStore, then the tools are not available to edit it
  
Show
Mauricio Pazos added a comment - - edited Unfortunately, I have realized we have not resolved the bug. The first time, when the layer is created, the ShowViewInterceptor.run method receives an UDIGFeatureStore, it is ok, because the tools can ediit it (the tools are available). But, if you close udig and reopen it, the same layer has a DefaultQuery. DefaultQuere is not a DataStore, then the tools are not available to edit it   
Hide
Permalink
Jody Garnett added a comment -
Can we check what the query is? Does it have Filter.INCLUDE?

I see some logic in there to convert a filter into a query; I am concerned it is picking up Filter.INCLUDE and turning it into a Query (and then turning the layer into a view).

Really we want it to ignore Filter.INCLUDE; this is the same mistake that I just fixed for WMS.
Show
Jody Garnett added a comment - Can we check what the query is? Does it have Filter.INCLUDE? I see some logic in there to convert a filter into a query; I am concerned it is picking up Filter.INCLUDE and turning it into a Query (and then turning the layer into a view). Really we want it to ignore Filter.INCLUDE; this is the same mistake that I just fixed for WMS.
Hide
Permalink
Mauricio Pazos added a comment -
It is a DefaultQuery with a Filter.INCLUDE. (It looks like it has the same problem that wms)
Show
Mauricio Pazos added a comment - It is a DefaultQuery with a Filter.INCLUDE. (It looks like it has the same problem that wms)
Hide
Permalink
Mauricio Pazos added a comment -
Rev: 31894: It was modified the criteria to enable the tools
FeatureStoreResourceProperty (lines 79 - 82)

 
Show
Mauricio Pazos added a comment - Rev: 31894: It was modified the criteria to enable the tools FeatureStoreResourceProperty (lines 79 - 82)  
Hide
Permalink
Mauricio Pazos added a comment -
Please, codereview before close
Show
Mauricio Pazos added a comment - Please, codereview before close

People

  • Assignee:
    Mauricio Pazos
    Reporter:
    Aritz Davila
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: