uDIG

Create Polygon Tool Validation Broken

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: UDIG 1.2.RC1
  • Fix Version/s: UDIG 1.2.RC2
  • Component/s: tools and editing
  • Labels:
    None

Description

Tony Roth sent the following mail:

Hi Developers,

an issue (GEOT-2958) that has been fixed for Geotools 2.6.2 causes an
incorrect behaviour of the PolygonTool. Finishing the creation of polygons
with a double click ends up in an error dialog, saying something like "The
geometry resulting from the edit is invalid. Undo the last edit command
(Ctrl+Z) and try again".

I think the reason for this could be the last modification of the
JTSUtilities class in gt-shapefile-2.6.2.jar. Have a look at the nested loop
in the following method:

   public static final LinearRing reverseRing(LinearRing lr) {
       GeometryFactory gf = lr.getFactory();
       CoordinateSequenceFactory csf = gf.getCoordinateSequenceFactory();

       CoordinateSequence csOrig = lr.getCoordinateSequence();
               int numPoints = csOrig.size();
               int dimensions = csOrig.getDimension();
               CoordinateSequence csNew = csf.create(numPoints, dimensions);

               for (int i = 0; i < numPoints; i++) {
                       for (int j = 0; j < dimensions; j++) {
                               csOrig.getOrdinate(i, j);
                       }
               }

       return gf.createLinearRing(csNew);
   }

The CoordinateSequence isn't filled with coordinates?

I might be on the wrong tack.
Tony

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. GEOT-2974 Shapefile: Storing counter clock wise polygons does not work - reverseRing() incorrect

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GEOT-2958 JTSUtilities does not honor the original geometry factory

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Jody Garnett made changes -
Field Original Value New Value
Description Tony Roth sent the following mail:
{panel}
Hi Developers,

an issue (GEOT-2958) that has been fixed for Geotools 2.6.2 causes an
incorrect behaviour of the PolygonTool. Finishing the creation of polygons
with a double click ends up in an error dialog, saying something like "The
geometry resulting from the edit is invalid. Undo the last edit command
(Ctrl+Z) and try again".

I think the reason for this could be the last modification of the
JTSUtilities class in gt-shapefile-2.6.2.jar. Have a look at the nested loop
in the following method:
{code}
   public static final LinearRing reverseRing(LinearRing lr) {
       GeometryFactory gf = lr.getFactory();
       CoordinateSequenceFactory csf = gf.getCoordinateSequenceFactory();

       CoordinateSequence csOrig = lr.getCoordinateSequence();
               int numPoints = csOrig.size();
               int dimensions = csOrig.getDimension();
               CoordinateSequence csNew = csf.create(numPoints,
dimensions);

               for (int i = 0; i < numPoints; i++) {
                       for (int j = 0; j < dimensions; j++) {
                               csOrig.getOrdinate(i, j);
                       }
               }

       return gf.createLinearRing(csNew);
   }
{code}
The CoordinateSequence isn't filled with coordinates?

I might be on the wrong tack.
Tony
{panel} 		Tony Roth sent the following mail:
{panel}
Hi Developers,

an issue (GEOT-2958) that has been fixed for Geotools 2.6.2 causes an
incorrect behaviour of the PolygonTool. Finishing the creation of polygons
with a double click ends up in an error dialog, saying something like "The
geometry resulting from the edit is invalid. Undo the last edit command
(Ctrl+Z) and try again".

I think the reason for this could be the last modification of the
JTSUtilities class in gt-shapefile-2.6.2.jar. Have a look at the nested loop
in the following method:
{code}
   public static final LinearRing reverseRing(LinearRing lr) {
       GeometryFactory gf = lr.getFactory();
       CoordinateSequenceFactory csf = gf.getCoordinateSequenceFactory();

       CoordinateSequence csOrig = lr.getCoordinateSequence();
               int numPoints = csOrig.size();
               int dimensions = csOrig.getDimension();
               CoordinateSequence csNew = csf.create(numPoints, dimensions);

               for (int i = 0; i < numPoints; i++) {
                       for (int j = 0; j < dimensions; j++) {
                               csOrig.getOrdinate(i, j);
                       }
               }

       return gf.createLinearRing(csNew);
   }
{code}
The CoordinateSequence isn't filled with coordinates?

I might be on the wrong tack.
Tony
{panel}
Jody Garnett made changes -
Link This issue depends upon GEOT-2958 [ GEOT-2958 ]
Jody Garnett made changes -
Link This issue depends upon GEOT-2974 [ GEOT-2974 ]
Hide
Permalink
Jody Garnett added a comment -
GEOT-2974 has a patch; waiting on a test case.
Show
Jody Garnett added a comment - GEOT-2974 has a patch; waiting on a test case.
Hide
Permalink
Jody Garnett added a comment -
Fixed up JTSUtilities.
Show
Jody Garnett added a comment - Fixed up JTSUtilities.
Jody Garnett made changes -
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Fix Version/s UDIG 1.2.0 [ 16264 ]
Jody Garnett made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Jody Garnett made changes -
Fix Version/s UDIG 1.2.RC2 [ 16287 ]
Fix Version/s UDIG 1.2.0 [ 16264 ]
Jody Garnett made changes -
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Jody Garnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: