IGeoResource.dispose() and Layer tracking

Details

Description

Found LayerResource (a proxy GeoResource that caches its value for later), it and I guess IGeoResource will need a dispose method.

Note LayerResource should listen to Catalog events to tell when its target has changed. It is also unclear who should take responsibility for telling Layer about its GeoResources changing.

I kind of expect that Layer should listen to catalog events, when in the Layer lifecycle should this occur.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Zwiers added a comment -
Hmm, we might just want a dispose method for the ICatalog ... as the IResource can very well be mapped to 2 Layer objects. We can use the event model provided by the catalog to inform the layer when the catalog, service or georesource has been modified (ie, deleted/closed in this case).

I would rather avoid dispose methods if at all posible, as the catalog instances are really just proxies ... alternatively we can also include cleanup-code in finalize (of the catalog, service + georesource) and the catalog plugin destructor.
Show
David Zwiers added a comment - Hmm, we might just want a dispose method for the ICatalog ... as the IResource can very well be mapped to 2 Layer objects. We can use the event model provided by the catalog to inform the layer when the catalog, service or georesource has been modified (ie, deleted/closed in this case). I would rather avoid dispose methods if at all posible, as the catalog instances are really just proxies ... alternatively we can also include cleanup-code in finalize (of the catalog, service + georesource) and the catalog plugin destructor.
Hide
Permalink
Jody Garnett added a comment -
finalize never really works, I agree that Catalog is the active party responsible for "all" resources. So we can have it hold the dispose method, basically we need someone to tell the Datastores to close.

I just wanted the *who* figured out.
Show
Jody Garnett added a comment - finalize never really works, I agree that Catalog is the active party responsible for "all" resources. So we can have it hold the dispose method, basically we need someone to tell the Datastores to close. I just wanted the *who* figured out.
Hide
Permalink
Jody Garnett added a comment -
GeoResource represents a lightweight handle that may be duplicated, it is not the proper object to hold onto resources (and thus require a dispose method).

The catalog holds onto resources (and gives out handles that may be redeemed later)
Show
Jody Garnett added a comment - GeoResource represents a lightweight handle that may be duplicated, it is not the proper object to hold onto resources (and thus require a dispose method). The catalog holds onto resources (and gives out handles that may be redeemed later)

People

  • Assignee:
    Jesse Eichar
    Reporter:
    Jody Garnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: