uDIG

wrong feature layer style visualization on trunk

Details

Description

using trunk I observed that there are two problems visualizing a shapefile:
1. if it is a line shapefile so it is displayed always in black even if you try to change the color display, if there are labels for the shapefile changing the color of the line withe the apposite tools it changes the color of the label text
2. if it is a polygon shapefile so it is displayed with black boundaries and colored fill

Attachments

  1. File
    styleproblem.sld
    30/Aug/08 1:13 AM
    2 kB
    Andrea Antonello
  1. Picture 3.png
    104 kB
    30/Aug/08 1:12 AM
  2. screenshot-1.jpg
    132 kB
    30/Aug/08 7:07 PM

Issue Links

This issue is related to:
UDIG-1424 PointSymbolizer settings ignore when rendering Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Antonello added a comment -
the wrong visualization
Show
Andrea Antonello added a comment - the wrong visualization
Hide
Permalink
Andrea Antonello added a comment -
the generate sld file, even if I do not think the problem is here
Show
Andrea Antonello added a comment - the generate sld file, even if I do not think the problem is here
Hide
Permalink
Jody Garnett added a comment -
Found the incorrect code in SLDStyleFactory; it was returning the "fallback" color of black if the parsed color was non null.

Commit as of -r31322 - we can deploy GeoTools and confirm the fix for uDig to close the bug.
Show
Jody Garnett added a comment - Found the incorrect code in SLDStyleFactory; it was returning the "fallback" color of black if the parsed color was non null. Commit as of -r31322 - we can deploy GeoTools and confirm the fix for uDig to close the bug.
Hide
Permalink
Jody Garnett added a comment -
Only half way there - renderer now does the correct thing. Next up we need to have a little chat with the style configurator.
Show
Jody Garnett added a comment - Only half way there - renderer now does the correct thing. Next up we need to have a little chat with the style configurator.
Hide
Permalink
Jody Garnett added a comment -
SLDStyleFactory is now able to deal with a literal; the style configurator will need to be checked over next.
Show
Jody Garnett added a comment - SLDStyleFactory is now able to deal with a literal; the style configurator will need to be checked over next.
Hide
Permalink
Jody Garnett added a comment -
SLDParser had several cases where the logger was checked in an if/elseif statement ... of if the logger was turned on nothing else would be processed

if( ..check logger... ){
   ...log
}
else if ( child is style ){
   ... create a color...
}
else if( child is style-width ){
  ... create a width
}
....

Removing the else if has solved the problem. However it does indicate that logging is turned on at a very low level here ... and is not visible in the console log. Perhaps this is a clue for why things are acting slowly when switching between layers.
Show
Jody Garnett added a comment - SLDParser had several cases where the logger was checked in an if/elseif statement ... of if the logger was turned on nothing else would be processed if( ..check logger... ){    ...log } else if ( child is style ){    ... create a color... } else if( child is style-width ){   ... create a width } .... Removing the else if has solved the problem. However it does indicate that logging is turned on at a very low level here ... and is not visible in the console log. Perhaps this is a clue for why things are acting slowly when switching between layers.
Hide
Permalink
Andrea Antonello added a comment -
This is not fixed for Point layers. In the case of point layers, when opening the style editor, the color is not the same as the layer points.
Show
Andrea Antonello added a comment - This is not fixed for Point layers. In the case of point layers, when opening the style editor, the color is not the same as the layer points.
Hide
Permalink
Jody Garnett added a comment -
Created a new bug report to track the similar problem with point symbolizer use
Show
Jody Garnett added a comment - Created a new bug report to track the similar problem with point symbolizer use

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.