Inaccurate value for the line width in Change Style dialog

Jody Garnett added a comment - 06/Mar/08 3:16 PM That is not cool; -1 is the value used to indicate that no line width was found :-( You may need to set a debugger breakpoint and see exactly where it is failing.

Maria Comanescu added a comment - 07/Mar/08 2:52 AM I set a breakpoint in method *setStroke*, class StrokeViewer.java(net.refractions.udig.style.sld) at line: SLDs.width(line); Description of line parameter

Maria Comanescu added a comment - 07/Mar/08 3:10 AM I appologize for the previous comment, I pressed Add by mistake :) So, I set a breakpoint in method setStroke, class StrokeViewer.java (net.refractions.udig.style.sld package) at line: SLDs.width(line); (line 223 in my code) The line parameter looks like this in Variables description: org.geotools.styling.StrokeImpl: Color #FF00FF Width 3.0 Opacity 0.75 LineCap butt LineJoin miter Dash Array [ F@155b814 Dash Offset 0.0 Fill Graphic null Stroke Graphic null The width is set (3.0) . Still the result of expression "SLDs.width(line)" is -1. Now, SLDs class extends SLD class, which I have in gt2-main.jar So the width function in SLD looks like this: public static int width(Stroke stroke) {         if (stroke == null) {             return NOTFOUND;         }         return intValue(stroke.getWidth());     }     public static int intValue(Expression expr) {         return Filters.asInt(expr);     } I guess the error occurs when the Filters.asInt(expr) method attempts to get an int value out of an expression containing "3.0" literal, which is more like double literal :) Fix method: I replaced in StrokeViewer.java line "SLDs.width(line)" with "this.width = Filters.asDouble(line.getWidth())" and it works fine. In my udig code I found 4 "SLD.width" method calls: - 2 in StrokeViewer.java (net.refractions.udig.style.sld) - 2 in Drawing.java (net.refractions.udig.ui) I replaced them all. So, I think there are two methods to fix this: either change udig code or change SLD class in geotools; but I'm not sure which one is the best fix

Jody Garnett added a comment - 12/Mar/08 4:34 PM Maria the problem is actually using a double for width; the specification calls for integer. For now I will fix up SLD.width( Expression ) code of Use expr.evaulate( null, Integer.class ) - this will let the expression subsystem convert from Double to Integer for us.