uDIG
  1. uDIG
  2. UDIG-1373

Exception when editing the style of multiple layers

    Details

      Description

      From email (thanks Maria):


      In order to reproduce the error, choose a layer, right-click to Change Style, the dialog appears, everything is fine. Close the window.
      Afterwards, right-click the Change Style button of another layer, and that's when the conflicts happen.

      !MESSAGE A handler conflict occurred.  This may disable some commands.
      !SUBENTRY 1 org.eclipse.ui.workbench 2 0 2008-03-05 16:24:00.174
      !MESSAGE Conflict for 'org.eclipse.ui.navigate.backwardHistory':
      HandlerActivation(commandId=org.eclipse.ui.navigate.backwardHistory,
              handler=ActionHandler(net.refractions.udig.style.sld.editor.internal.PageHistoryHolder$1@1d2822f),
              expression=,sourcePriority=0)
      HandlerActivation(commandId=org.eclipse.ui.navigate.backwardHistory,
              handler=ActionHandler(net.refractions.udig.style.sld.editor.internal.PageHistoryHolder$1@1610393),
              expression=,sourcePriority=0)
      

      I've debuged, and the conflicts apear in PageHistoryHolder class, within the method registerKeybindings.

      So, I decided to cleanup the PageHistoryHolder resources by calling the dispose() method from the FilteredEditorDialog.close() method "if (history!= null ) history.dispose()" and it works fine.

      # FilteredEditorDialog.java
      public boolean close() {
                      if (history!= null ) history.dispose();
                      return super.close();
              } 
      

        Activity

        Hide
        Jody Garnett added a comment -
        Thanks for the fix.
        - applied to trunk -r29611
        - applied to 1.1.x -r29612
        Show
        Jody Garnett added a comment - Thanks for the fix. - applied to trunk -r29611 - applied to 1.1.x -r29612

          People

          • Assignee:
            Jody Garnett
            Reporter:
            Jody Garnett
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: