IRC conversation:
lotu: ping jgarnett
lotu: okay
lotu: you here?
jgarnett: I am here now
jgarnett: (I am just doing a user interface mock up for this:
http://udig.refractions.net/confluence/display/HACK/Temporal+Support+with+a+Navigation+View)
jgarnett: so what I would like to do is go over your patch; what you were trying to accomplish
jgarnett: and review how you went about it.
jgarnett: and then give you the go ahead to apply the patch.
lotu: alright, looking
jgarnett: as you can see others have been here before us; and made a bit of a mess.
jgarnett: however one of the udig guidelines; is code it like you mean it!
jgarnett: can I just confirm that you have svn access?
lotu: no I do not
jgarnett: I am willing to split the work with you; I can apply the patch to trunk/
jgarnett: okay that will be the first step; can you send an email to
admin@refractions.net and we will get you set up
jgarnett: mean while lets find a link to your bug report....
lotu:
http://jira.codehaus.org/browse/UDIG-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126389
jgarnett: my next question is; we took a few steps in the right direction for RC14 - we seperate out the udig product stuff from net.refractions.udig.ui
jgarnett: did that help you when you placed udig into your existing app?
lotu: Not really, right now we are just using uDig as a set of plugins to eclipse.
jgarnett: okay
jgarnett: your bug report says "I have used to patch to allows udig to load all it's functionally as an Eclipse plugin."
jgarnett: what do you mean exactly
jgarnett: did you change to the new menu extention point; or place a bunch of null checks in ...
lotu: I think I just fixed a bunch of the null checks that were borken and throwing exceptions.
jgarnett: sounds good
jgarnett: now remember I said people had been hacking before us; there were/are actually two ways to "setup" your menus in udig
lotu: yes I noticed that problem
jgarnett: some stupid extention point they made in a hurry; and the usual RCP way
jgarnett: (grumble)
jgarnett: did you have to fix both cases?
kartben [n=kartben@pur31-3-82-240-189-250.fbx.proxad.net] entered the room.
lotu: no I just made a small patch to fix the RCP way
jgarnett: understood
jgarnett: okay well lets get you svn access and then you can apply the patch
jgarnett: I will review as I merge it onto trunk?
lotu: Alright
jgarnett: and thanks for taking the time to talk on IRC; this would of taken longer on email.
lotu: So where should I be applying the patch to
jgarnett: 1.1.x
lotu: okay cool
jgarnett: let me know the svn revision as a comment on the bug report
jgarnett: and I will apply that to trunk
lotu: alright
jgarnett: so we should get back to you on svn login stuff real soon
jgarnett: (and welcome to open source development)
jgarnett: we try and make it easy
lotu: thank you
I have restructured the UDIGApplication class so the "test JAI" and "test GDI" methods are available for other application writers. Other than that I was holding off on this use-case in the hopes that switching to the Eclipse 3.3.x menu extension point would help matters. I have documented the menus required by a hosting application on the wiki but I admit that is not solution.