uDIG
  1. uDIG
  2. UDIG-1369

mapeditor dosen't work as a plugin

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: UDIG 1.1-RC14
    • Fix Version/s: UDIG 1.2.M0
    • Component/s: application
    • Labels:
      None
    • Environment:
      RCP 3.3.1.1
      windows XP

      Description

      When using uDig as a plugin to other applications, those applications have to correctly set up the their menus to keep uDig happy. Otherwise uDig throws exceptions when the map editor is opend.
      I have attached a patch to fix this. I have used to patch to allows udig to load all it's functionally as an Eclipse plugin.

        Activity

        Hide
        Jody Garnett added a comment -
        It would be good to chat with you via skype or IRC and go over this patch.

        I have restructured the UDIGApplication class so the "test JAI" and "test GDI" methods are available for other application writers. Other than that I was holding off on this use-case in the hopes that switching to the Eclipse 3.3.x menu extension point would help matters. I have documented the menus required by a hosting application on the wiki but I admit that is not solution.
        Show
        Jody Garnett added a comment - It would be good to chat with you via skype or IRC and go over this patch. I have restructured the UDIGApplication class so the "test JAI" and "test GDI" methods are available for other application writers. Other than that I was holding off on this use-case in the hopes that switching to the Eclipse 3.3.x menu extension point would help matters. I have documented the menus required by a hosting application on the wiki but I admit that is not solution.
        Hide
        Jody Garnett added a comment -
        IRC conversation:
        lotu: ping jgarnett
        lotu: okay
        lotu: you here?
        jgarnett: I am here now
        jgarnett: (I am just doing a user interface mock up for this: http://udig.refractions.net/confluence/display/HACK/Temporal+Support+with+a+Navigation+View)
        jgarnett: so what I would like to do is go over your patch; what you were trying to accomplish
        jgarnett: and review how you went about it.
        jgarnett: and then give you the go ahead to apply the patch.
        lotu: alright, looking
        jgarnett: as you can see others have been here before us; and made a bit of a mess.
        jgarnett: however one of the udig guidelines; is code it like you mean it!
        jgarnett: can I just confirm that you have svn access?
        lotu: no I do not
        jgarnett: I am willing to split the work with you; I can apply the patch to trunk/
        jgarnett: okay that will be the first step; can you send an email to admin@refractions.net and we will get you set up
        jgarnett: mean while lets find a link to your bug report....
        lotu: http://jira.codehaus.org/browse/UDIG-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126389
        jgarnett: my next question is; we took a few steps in the right direction for RC14 - we seperate out the udig product stuff from net.refractions.udig.ui
        jgarnett: did that help you when you placed udig into your existing app?
        lotu: Not really, right now we are just using uDig as a set of plugins to eclipse.
        jgarnett: okay
        jgarnett: your bug report says "I have used to patch to allows udig to load all it's functionally as an Eclipse plugin."
        jgarnett: what do you mean exactly
        jgarnett: did you change to the new menu extention point; or place a bunch of null checks in ...
        lotu: I think I just fixed a bunch of the null checks that were borken and throwing exceptions.
        jgarnett: sounds good
        jgarnett: now remember I said people had been hacking before us; there were/are actually two ways to "setup" your menus in udig
        lotu: yes I noticed that problem
        jgarnett: some stupid extention point they made in a hurry; and the usual RCP way
        jgarnett: (grumble)
        jgarnett: did you have to fix both cases?
        kartben [n=kartben@pur31-3-82-240-189-250.fbx.proxad.net] entered the room.
        lotu: no I just made a small patch to fix the RCP way
        jgarnett: understood
        jgarnett: okay well lets get you svn access and then you can apply the patch
        jgarnett: I will review as I merge it onto trunk?
        lotu: Alright
        jgarnett: and thanks for taking the time to talk on IRC; this would of taken longer on email.
        lotu: So where should I be applying the patch to
        jgarnett: 1.1.x
        lotu: okay cool
        jgarnett: let me know the svn revision as a comment on the bug report
        jgarnett: and I will apply that to trunk
        lotu: alright
        jgarnett: so we should get back to you on svn login stuff real soon
        jgarnett: (and welcome to open source development)
        jgarnett: we try and make it easy
        lotu: thank you
        Show
        Jody Garnett added a comment - IRC conversation: lotu: ping jgarnett lotu: okay lotu: you here? jgarnett: I am here now jgarnett: (I am just doing a user interface mock up for this: http://udig.refractions.net/confluence/display/HACK/Temporal+Support+with+a+Navigation+View) jgarnett: so what I would like to do is go over your patch; what you were trying to accomplish jgarnett: and review how you went about it. jgarnett: and then give you the go ahead to apply the patch. lotu: alright, looking jgarnett: as you can see others have been here before us; and made a bit of a mess. jgarnett: however one of the udig guidelines; is code it like you mean it! jgarnett: can I just confirm that you have svn access? lotu: no I do not jgarnett: I am willing to split the work with you; I can apply the patch to trunk/ jgarnett: okay that will be the first step; can you send an email to admin@refractions.net and we will get you set up jgarnett: mean while lets find a link to your bug report.... lotu: http://jira.codehaus.org/browse/UDIG-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126389 jgarnett: my next question is; we took a few steps in the right direction for RC14 - we seperate out the udig product stuff from net.refractions.udig.ui jgarnett: did that help you when you placed udig into your existing app? lotu: Not really, right now we are just using uDig as a set of plugins to eclipse. jgarnett: okay jgarnett: your bug report says "I have used to patch to allows udig to load all it's functionally as an Eclipse plugin." jgarnett: what do you mean exactly jgarnett: did you change to the new menu extention point; or place a bunch of null checks in ... lotu: I think I just fixed a bunch of the null checks that were borken and throwing exceptions. jgarnett: sounds good jgarnett: now remember I said people had been hacking before us; there were/are actually two ways to "setup" your menus in udig lotu: yes I noticed that problem jgarnett: some stupid extention point they made in a hurry; and the usual RCP way jgarnett: (grumble) jgarnett: did you have to fix both cases? kartben [n=kartben@pur31-3-82-240-189-250.fbx.proxad.net] entered the room. lotu: no I just made a small patch to fix the RCP way jgarnett: understood jgarnett: okay well lets get you svn access and then you can apply the patch jgarnett: I will review as I merge it onto trunk? lotu: Alright jgarnett: and thanks for taking the time to talk on IRC; this would of taken longer on email. lotu: So where should I be applying the patch to jgarnett: 1.1.x lotu: okay cool jgarnett: let me know the svn revision as a comment on the bug report jgarnett: and I will apply that to trunk lotu: alright jgarnett: so we should get back to you on svn login stuff real soon jgarnett: (and welcome to open source development) jgarnett: we try and make it easy lotu: thank you
        Hide
        Harry Bullen added a comment -
        I've applied a quick patch at r29572. This allow uDig to work but some menus (Layer and Map) don't show up at all.
        Show
        Harry Bullen added a comment - I've applied a quick patch at r29572. This allow uDig to work but some menus (Layer and Map) don't show up at all.
        Hide
        Jody Garnett added a comment -
        Thanks - reviewed and applied to trunk as of -r29575
        Show
        Jody Garnett added a comment - Thanks - reviewed and applied to trunk as of -r29575
        Hide
        Jody Garnett added a comment -
        You are correct; the developers guide has some documentation about that if you are interested. I am interested in your feedback; to really work on this I need a "normal" RCP app in tutorials that we can use as a test victim. Perhaps the Hello World RCP app would do...

        You may also want to check that the ActionSets are turned on in your perspective for some of the Map / Layer menus?
        Show
        Jody Garnett added a comment - You are correct; the developers guide has some documentation about that if you are interested. I am interested in your feedback; to really work on this I need a "normal" RCP app in tutorials that we can use as a test victim. Perhaps the Hello World RCP app would do... You may also want to check that the ActionSets are turned on in your perspective for some of the Map / Layer menus?

          People

          • Assignee:
            Unassigned
            Reporter:
            Harry Bullen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: