Tynamo

Redirects should honor localization

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: security-0.3.1
  • Fix Version/s: security-0.4.1
  • Component/s: security
  • Labels:
    None
  • Environment:
    Tapestry: 5.2.4
  • Number of attachments :
    0

Description

Tapestry uses an url scheme of specifying localization after context-path.
Like /page, /en/page, /fi/page

Currently(I believe) tapestry-security is not page-aware.
It would be good if it was possible to specify PAGES instead of urls so that localization would no be lost.

Probably some users would still need the option of specifying a resource. This could be a standard servlet or jsp.

One suggestion: could pages perhaps be specified in a tapestryish way by using a prefix...

configuration.add(SecuritySymbols.SUCCESS_URL, "page:welcome");
configuration.add(SecuritySymbols.LOGIN_URL, "/login.jsp");

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kalle Korhonen added a comment -

To elaborate, the url protecting scheme of tapestry-security isn't Tapestry/page aware at the moment. Use annotations for page-specific protection. In any case though, I agree we can make the url-based protection more Tapestry aware.

Show
Kalle Korhonen added a comment - To elaborate, the url protecting scheme of tapestry-security isn't Tapestry/page aware at the moment. Use annotations for page-specific protection. In any case though, I agree we can make the url-based protection more Tapestry aware.
Hide
Permalink
Kalle Korhonen added a comment -

The title is relevant to the issue and is fixed. We are not changing the notation for url-filtering, it has its purpose. Annotations are meant for page specific security.

Show
Kalle Korhonen added a comment - The title is relevant to the issue and is fixed. We are not changing the notation for url-filtering, it has its purpose. Annotations are meant for page specific security.
Hide
Permalink
Lenny Primak added a comment -

I see there is an initiative to remove PageService.
I override this service to insert logic into SuccessURL, etc.
Please undeprecate / don't remove it.

Thanks

Show
Lenny Primak added a comment - I see there is an initiative to remove PageService. I override this service to insert logic into SuccessURL, etc. Please undeprecate / don't remove it. Thanks

People

  • Assignee:
    Kalle Korhonen
    Reporter:
    Magnus Kvalheim
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: