Tynamo
  1. Tynamo
  2. TYNAMO-182

Support GitHub federated login

    Details

    • Number of attachments :
      6
    1. TYNAMO-182.patch
      24 kB
      Dmitry Gusev
    2. TYNAMO-182-2.patch
      4 kB
      Dmitry Gusev
    1. displayMode-fancy.png
      18 kB
    2. displayMode-plaintext.png
      12 kB
    3. GitHub_Logo.png
      9 kB
    4. Octocat.png
      19 kB

      Activity

      Hide
      Dmitry Gusev added a comment -

      Initial implementation for tynamo-federatedaccounts-github

      Show
      Dmitry Gusev added a comment - Initial implementation for tynamo-federatedaccounts-github
      Hide
      Kalle Korhonen added a comment -

      Need to re-evaluate Scribe usage before closing.

      Show
      Kalle Korhonen added a comment - Need to re-evaluate Scribe usage before closing.
      Hide
      Dmitry Gusev added a comment -

      I've updated to your changes and getting this exception:

      Exception assembling embedded component 'githuboauthsignin' (of type org.tynamo.security.federatedaccounts.github.components.GitHubOauthSignIn, within Index:layout): Could not convert 'asset:GitHub_Logo.png' into a component parameter binding: Unable to locate asset 'classpath:org/tynamo/security/federatedaccounts/github/components/GitHub_Logo.png' (the file does not exist).

      Couldn't find GitHub_Logo.png and Octocat.png ... are you plan to include them?
      Or, probably, we should remove these assets from *.tml and support UI customizations.

      Show
      Dmitry Gusev added a comment - I've updated to your changes and getting this exception: Exception assembling embedded component 'githuboauthsignin' (of type org.tynamo.security.federatedaccounts.github.components.GitHubOauthSignIn, within Index:layout): Could not convert 'asset:GitHub_Logo.png' into a component parameter binding: Unable to locate asset 'classpath:org/tynamo/security/federatedaccounts/github/components/GitHub_Logo.png' (the file does not exist). Couldn't find GitHub_Logo.png and Octocat.png ... are you plan to include them? Or, probably, we should remove these assets from *.tml and support UI customizations.
      Hide
      Dmitry Gusev added a comment -

      The images didn't appear in patch, sorry.
      They should be in resources/.../components/

      Show
      Dmitry Gusev added a comment - The images didn't appear in patch, sorry. They should be in resources/.../components/
      Hide
      Dmitry Gusev added a comment -

      Customize display mode of SingIn component

      New parameters:

      • displayMode, values may be
        'plaintext', 'fancy' and 'custom'
      • displayText – text to display (default is 'Sign In with GitHub')
      • displayBlock – used when displayMode = custom
      Show
      Dmitry Gusev added a comment - Customize display mode of SingIn component New parameters: displayMode, values may be 'plaintext', 'fancy' and 'custom' displayText – text to display (default is 'Sign In with GitHub') displayBlock – used when displayMode = custom
      Hide
      Dmitry Gusev added a comment -

      Examples of displayMode=fancy and displayMode=plaintext

      Show
      Dmitry Gusev added a comment - Examples of displayMode=fancy and displayMode=plaintext
      Hide
      Kalle Korhonen added a comment -

      Initial support in via the new federatedaccounts-pac4jbasedoauth module. Removed tynamo-federatedaccounts-github since a specific provider support based on generic implementation such as scribe doesn't make sense. Take a look, the signIn component, window modes etc. could probably use some love and flexibility. I do want to support your use case with this module. Going to make a release in the near future.

      Show
      Kalle Korhonen added a comment - Initial support in via the new federatedaccounts-pac4jbasedoauth module. Removed tynamo-federatedaccounts-github since a specific provider support based on generic implementation such as scribe doesn't make sense. Take a look, the signIn component, window modes etc. could probably use some love and flexibility. I do want to support your use case with this module. Going to make a release in the near future.

        People

        • Assignee:
          Kalle Korhonen
          Reporter:
          Dmitry Gusev
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: