Tynamo
  1. Tynamo
  2. TYNAMO-143

Create a marker annotation for SecurityConfiguration

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: security-0.4.5
    • Component/s: security
    • Labels:
      None
    • Number of attachments :
      0

      Description

      I would like to have a marker annotation for SecurityConfiguration. Maybe @SecurityConfiguration?
      The idea is to avoid the contributeSecurityConfiguration naming convention in my AppModule and use something like this:

      @Contribute(HttpServletRequestFilter.class)
      @Marker(@SecurityConfiguration.class)
      public static void setupSecurity(Configuration<SecurityFilterChain> configuration,
                                                         SecurityFilterChainFactory factory)
      {
      ...
      

        Activity

        Hide
        Kalle Korhonen added a comment -

        Following T5's naming conventions, I named the marker just @Security. Surprisingly, that only collides with java.security.Security which feels better to me than having both an service impl class SecurityConfiguration and an annotation @SecurityConfiguration in (almost) the same namespace.

        Show
        Kalle Korhonen added a comment - Following T5's naming conventions, I named the marker just @Security. Surprisingly, that only collides with java.security.Security which feels better to me than having both an service impl class SecurityConfiguration and an annotation @SecurityConfiguration in (almost) the same namespace.
        Hide
        Alejandro Scandroli added a comment -

        bulk closing issues that have been resolved for more than a year.

        Show
        Alejandro Scandroli added a comment - bulk closing issues that have been resolved for more than a year.

          People

          • Assignee:
            Kalle Korhonen
            Reporter:
            Alejandro Scandroli
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: