Tynamo
  1. Tynamo
  2. TYNAMO-106

Login screen background file (login-bg.png) is too large for the web - smaller file attached

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: security-0.4.0
    • Fix Version/s: security-0.4.1
    • Component/s: security
    • Labels:
      None
    • Environment:
      All
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      The file is almost 200k, noticeably slow in loading.
      Smaller file and imperceptible in quality is attached.

        Activity

        Hide
        Alejandro Scandroli added a comment -

        Hi Lenny, I have checked in a fix for this.
        The attached file is actually the wrong size, the original file was 778x660.

        Instead of using the file you attached I just converted the original file from png to jpg. Let me know if you think that's good enough.

        Show
        Alejandro Scandroli added a comment - Hi Lenny, I have checked in a fix for this. The attached file is actually the wrong size, the original file was 778x660. Instead of using the file you attached I just converted the original file from png to jpg. Let me know if you think that's good enough.
        Hide
        Lenny Primak added a comment -

        I don't think the size would make a difference, as the CSS width/height is specified:

        #tynamoLoginFormContainer {
        background: url($

        {asset:classpath:org/tynamo/security/img/login-bg.png}

        ) no-repeat;
        width:778px;
        height:600px;
        margin:0 auto;
        }

        I don't think .jpg file would work in this case, since there is transparency involved here,
        and .jpg will not handle that.

        What do you think?

        Show
        Lenny Primak added a comment - I don't think the size would make a difference, as the CSS width/height is specified: #tynamoLoginFormContainer { background: url($ {asset:classpath:org/tynamo/security/img/login-bg.png} ) no-repeat; width:778px; height:600px; margin:0 auto; } I don't think .jpg file would work in this case, since there is transparency involved here, and .jpg will not handle that. What do you think?
        Hide
        Alejandro Scandroli added a comment -

        It's a background image so without a background-size it won't stretch.
        I think the transparency is not a problem given that the page is mostly white.

        Have you tried the checked in file and the new form?

        Show
        Alejandro Scandroli added a comment - It's a background image so without a background-size it won't stretch. I think the transparency is not a problem given that the page is mostly white. Have you tried the checked in file and the new form?
        Hide
        Lenny Primak added a comment -

        Larger image, still PNG, still transparent

        Show
        Lenny Primak added a comment - Larger image, still PNG, still transparent
        Hide
        Lenny Primak added a comment -

        I didn't try the new form, because I didn't originally compile the code.
        But, I do see that it doesn't stretch and re-attached a properly sized and tested image.
        It's still PNG, and still smaller than the JPG image and preserves transparency.

        Show
        Lenny Primak added a comment - I didn't try the new form, because I didn't originally compile the code. But, I do see that it doesn't stretch and re-attached a properly sized and tested image. It's still PNG, and still smaller than the JPG image and preserves transparency.
        Hide
        Alejandro Scandroli added a comment -

        Done!
        Thanks Lenny.

        Show
        Alejandro Scandroli added a comment - Done! Thanks Lenny.

          People

          • Assignee:
            Alejandro Scandroli
            Reporter:
            Lenny Primak
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: