Trails

To avoid double submit and refresh issues we should implement some sort of "redirect after post" pattern

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.0, 1.1.0, 1.2.0
  • Fix Version/s: 1.2.0
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

Although we can't use it everywhere, we should consider it, for instance, for going back to "ListPage" from "EditPage".

Issue Links

Activity

Hide
Ken in nashua added a comment -

I did synchronized double click serv(er)(let) code about 15 years ago on clickRelease (throw away events that are deemed throw-away (double post, refresh).

I am wondering (I don't know as of yet) what the feasibility of Ajax would be such that a centralized button release handler intercepted all incoming buttonReleases and scanned them determining validity before posting.

Just a thought...

I am checking out the pattern for redirect-post.

If I come up with a prototype I will advise.

Show
Ken in nashua added a comment - I did synchronized double click serv(er)(let) code about 15 years ago on clickRelease (throw away events that are deemed throw-away (double post, refresh). I am wondering (I don't know as of yet) what the feasibility of Ajax would be such that a centralized button release handler intercepted all incoming buttonReleases and scanned them determining validity before posting. Just a thought... I am checking out the pattern for redirect-post. If I come up with a prototype I will advise.
Hide
Ken in nashua added a comment -

Alejandro,

How do you feel about this solution?

http://howardlewisship.com/tapestry-javaforge/tapestry-flash/

Ken

Show
Ken in nashua added a comment - Alejandro, How do you feel about this solution? http://howardlewisship.com/tapestry-javaforge/tapestry-flash/ Ken
Hide
Ken in nashua added a comment -

Patched with redirect-after-post design pattern implemented by EditPage.JAVA:onFormSubmit()

Show
Ken in nashua added a comment - Patched with redirect-after-post design pattern implemented by EditPage.JAVA:onFormSubmit()
Hide
Ken in nashua added a comment -

revision 479

Show
Ken in nashua added a comment - revision 479
Hide
Alejandro Scandroli added a comment -

the solution proposed for TRAILS-35 has some side effects, they should be fixed when TRAILS-42 is fixed.

Show
Alejandro Scandroli added a comment - the solution proposed for TRAILS-35 has some side effects, they should be fixed when TRAILS-42 is fixed.
Hide
Alejandro Scandroli added a comment -

Attached is a patch with a possible solution. I'm still figuring out the testcases.

Show
Alejandro Scandroli added a comment - Attached is a patch with a possible solution. I'm still figuring out the testcases.
Hide
Alejandro Scandroli added a comment -

Well Ken that is how a patch file looks like.
You can use subclipse to apply it, or you can also use the svn patch command.

Show
Alejandro Scandroli added a comment - Well Ken that is how a patch file looks like. You can use subclipse to apply it, or you can also use the svn patch command.
Hide
Alejandro Scandroli added a comment -

New patch, this one includes working testcases.

Show
Alejandro Scandroli added a comment - New patch, this one includes working testcases.
Hide
Alejandro Scandroli added a comment -

Using "redirect after post" pattern affects our callback stack, specially when editing child collections.
I think we should postpone this issue until we figure out how to handle the callbacks.

Show
Alejandro Scandroli added a comment - Using "redirect after post" pattern affects our callback stack, specially when editing child collections. I think we should postpone this issue until we figure out how to handle the callbacks.
Hide
Alejandro Scandroli added a comment -

The new TrailsPagesService allows to seamlessly integrate this pattern.

Show
Alejandro Scandroli added a comment - The new TrailsPagesService allows to seamlessly integrate this pattern.
Hide
Ken in nashua added a comment -

Fails on 1.2

Show
Ken in nashua added a comment - Fails on 1.2

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: