jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • sysunit
  • SYSUNIT-3

SystemTestCase incorrectly uses the TestResult failure count to determine if the current SystemTestCase was sucessful.

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-3
  • Fix Version/s: 1.0-beta-3
  • Labels:
    None
  • Environment:
    WinXP SP2 with jdk 1.4.2-10
    Dell Latitude D600 using Intel M processor with 1gb of ram
  • Testcase included:
    yes

Description

The SystemTestCase class uses the passed TestResult to determine if the current system test case was successful or not.

It does not take into account that the SystemTestCase can be part of a set of tests for a given run. It is possible that a previous test generated a failure. This will cause the runTest performRun and performAssertValid methods not be to be called.

The suggested fix is that we use a boolean attribute that is set whenever the system test fails. This can be done by using a TestListener. This listener is added before the test is started and is remove when the test was completed. The boolean attribute is then used to determine if the performRun and performAssertValid is called or not.

Attached a suggested fix and a test case that was added to the SystemTestCaseTest test.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Hide
    Zip Archive
    patch.zip
    18/Jan/06 10:21 AM
    1 kB
    Claudio Corsi
    1. File
      diffs 3 kB
    2. Java Source File
      src/.../SystemTestCase_AssertValidCalled.java 0.7 kB
    Download Zip
    Show
    Zip Archive
    patch.zip
    18/Jan/06 10:21 AM
    1 kB
    Claudio Corsi
  2. Hide
    Zip Archive
    patch.zip
    16/Jan/06 11:17 PM
    1 kB
    Claudio Corsi
    1. File
      diffs 3 kB
    2. Java Source File
      src/.../SystemTestCase_AssertValidCalled.java 1 kB
    Download Zip
    Show
    Zip Archive
    patch.zip
    16/Jan/06 11:17 PM
    1 kB
    Claudio Corsi

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Claudio Corsi added a comment - 18/Jan/06 10:21 AM

The previous attachment included some print statements that should not have been their. I have attached an updated version that do not include the print statements.

Show
Claudio Corsi added a comment - 18/Jan/06 10:21 AM The previous attachment included some print statements that should not have been their. I have attached an updated version that do not include the print statements.
Hide
Permalink
Claudio Corsi added a comment - 27/Jan/06 10:56 AM

This issue has been commit

Show
Claudio Corsi added a comment - 27/Jan/06 10:56 AM This issue has been commit
Hide
Permalink
Claudio Corsi added a comment - 27/Jan/06 10:56 AM

Resolved.

Show
Claudio Corsi added a comment - 27/Jan/06 10:56 AM Resolved.

People

  • Assignee:
    Unassigned
    Reporter:
    Claudio Corsi
Vote (0)
Watch (0)

Dates

  • Created:
    16/Jan/06 11:17 PM
    Updated:
    27/Jan/06 10:56 AM
    Resolved:
    27/Jan/06 10:56 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.