SymmetricDS

java.util.ConcurrentModificationException while registering replica node

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.7.16
  • Fix Version/s: 1.7.17
  • Component/s: Registration
  • Labels:
    None
  • Environment:
    OS: CentOS
    AS: JBoss
  • Number of attachments :
    0

Description

Faced the issue below while registering multiple replica node

2011-07-29 13:36:49,926 ERROR [org.jumpmind.symmetric.web.SymmetricServlet] Error while processing GET request for externalId: null, node: blade2vm47.smgr.com at 172.16.20.47 (172.16.20.47)
java.util.ConcurrentModificationException
at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
at java.util.AbstractList$Itr.next(AbstractList.java:343)
at org.apache.ddlutils.model.Database.findTable(Database.java:430)
at org.apache.ddlutils.model.Database.findTable(Database.java:414)
at org.jumpmind.symmetric.db.AbstractDbDialect.getMetaDataFor(AbstractDbDialect.java:278)
at org.jumpmind.symmetric.db.AbstractDbDialect.getMetaDataFor(AbstractDbDialect.java:267)
at org.jumpmind.symmetric.service.impl.DataExtractorService.extractConfiguration(DataExtractorService.java:158)
at org.jumpmind.symmetric.service.impl.DataExtractorService.extractConfigurationStandalone(DataExtractorService.java:135)
at org.jumpmind.symmetric.service.impl.DataExtractorService.extractConfigurationStandalone(DataExtractorService.java:101)
at org.jumpmind.symmetric.service.impl.RegistrationService.registerNode(RegistrationService.java:134)
at org.jumpmind.symmetric.transport.handler.PullResourceHandler.pull(PullResourceHandler.java:53)
at org.jumpmind.symmetric.web.PullServlet.handlePost(PullServlet.java:66)
at org.jumpmind.symmetric.web.PullServlet.handleGet(PullServlet.java:49)
at org.jumpmind.symmetric.web.SymmetricServlet.handleGet(SymmetricServlet.java:133)
at org.jumpmind.symmetric.web.AbstractServlet.doGet(AbstractServlet.java:98)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.jumpmind.symmetric.web.SymmetricFilter$SymmetricFilterChain.doFilter(SymmetricFilter.java:151)
at org.jumpmind.symmetric.web.SymmetricFilter$SymmetricFilterChain.doFilter(SymmetricFilter.java:145)
at org.jumpmind.symmetric.web.compression.CompressionFilter.doFilter(CompressionFilter.java:157)
at org.jumpmind.symmetric.web.CompressionFilter.doFilter(CompressionFilter.java:73)
at org.jumpmind.symmetric.web.SymmetricFilter$SymmetricFilterChain.doFilter(SymmetricFilter.java:143)
at org.jumpmind.symmetric.web.NodeConcurrencyFilter.doFilter(NodeConcurrencyFilter.java:74)
at org.jumpmind.symmetric.web.SymmetricFilter$SymmetricFilterChain.doFilter(SymmetricFilter.java:143)
at org.jumpmind.symmetric.web.InetAddressFilter.doFilter(InetAddressFilter.java:89)
at org.jumpmind.symmetric.web.SymmetricFilter$SymmetricFilterChain.doFilter(SymmetricFilter.java:143)
at org.jumpmind.symmetric.web.AuthenticationFilter.doFilter(AuthenticationFilter.java:68)
at org.jumpmind.symmetric.web.SymmetricFilter$SymmetricFilterChain.doFilter(SymmetricFilter.java:143)
at org.jumpmind.symmetric.web.SymmetricFilter.doFilter(SymmetricFilter.java:76)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:182)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:524)
at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:84)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Henson added a comment -

What database are you using?

Show
Chris Henson added a comment - What database are you using?
Hide
Permalink
Shridhar Polas added a comment -

PostgreSQL 9.0.2 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-48), 64-bit

Show
Shridhar Polas added a comment - PostgreSQL 9.0.2 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-48), 64-bit
Hide
Permalink
Chris Henson added a comment -

There are bugs in the JDBC driver that is packaged with the 1.x series of SymmetricDS. We have upgraded the JDBC driver (which also required code changes) to solve many concurrency issues. Is upgrading to 2.3.1 an option. An upgrade from 1.7 to 2.3 will take some reconfiguration work and would need to be planned out. It isn't a simple drop and replace upgrade ...

Show
Chris Henson added a comment - There are bugs in the JDBC driver that is packaged with the 1.x series of SymmetricDS. We have upgraded the JDBC driver (which also required code changes) to solve many concurrency issues. Is upgrading to 2.3.1 an option. An upgrade from 1.7 to 2.3 will take some reconfiguration work and would need to be planned out. It isn't a simple drop and replace upgrade ...
Hide
Permalink
Shridhar Polas added a comment -

At this point in time we can not move to 2.x or upgrade to 2.x, we require the fix in 1.7.x
We have too many deployments where the SymmetricDS v1.7.x is being used. This issue is reported by one of our customer where they are doing simultaneous registration of many (>100) replica node. Is there a way to fix this issue in SymmetricDS v1.7.x?

Show
Shridhar Polas added a comment - At this point in time we can not move to 2.x or upgrade to 2.x, we require the fix in 1.7.x We have too many deployments where the SymmetricDS v1.7.x is being used. This issue is reported by one of our customer where they are doing simultaneous registration of many (>100) replica node. Is there a way to fix this issue in SymmetricDS v1.7.x?
Hide
Permalink
Chris Henson added a comment -

The fix isn't a high priority for the open source stack because it hasn't been in much demand. We'll add it to the queue and get to it eventually. If you need the fix expedited, please contact support@jumpmind.com.

Show
Chris Henson added a comment - The fix isn't a high priority for the open source stack because it hasn't been in much demand. We'll add it to the queue and get to it eventually. If you need the fix expedited, please contact support@jumpmind.com.
Hide
Permalink
Shridhar Polas added a comment -

We have plan to upgrade to v2.x and to go for paid support with jumpmind.
But, for v1.7.x we have already many deployments at customer end and the feasibility to go for paid support in this release is very remote.

I had a quick look in the Symmetric code to find how can this issue be fix by doing little change in code. Please share your thoughts on the code change below.

In method at line: org.jumpmind.symmetric.db.AbstractDbDialect.getMetaDataFor(AbstractDbDialect.java:278)

Current code:

public Table getMetaDataFor(String catalogName, String schemaName, String tableName, boolean useCache) {
Table retTable = cachedModel.findTable(tableName);
if (retTable == null || !useCache) {
synchronized (this.getClass()) {
try {
Table table = findTable(catalogName, schemaName, tableName);

if (retTable != null)

{ cachedModel.removeTable(retTable); }

if (table != null) { cachedModel.addTable(table); }

retTable = table;
} catch (RuntimeException ex) { throw ex; } catch (Exception ex) { throw new RuntimeException(ex); }
}
}
return retTable;
}



Modified code:

public Table getMetaDataFor(String catalogName, String schemaName, String tableName, boolean useCache) {
Table retTable = null;
synchronized (this.getClass()) {
retTable = cachedModel.findTable(tableName);
if (retTable == null || !useCache) {
try {
Table table = findTable(catalogName, schemaName, tableName);

if (retTable != null) { cachedModel.removeTable(retTable); }

if (table != null)

{ cachedModel.addTable(table); }

retTable = table;
} catch (RuntimeException ex)

{ throw ex; }

catch (Exception ex)

{ throw new RuntimeException(ex); }

}
}
return retTable;
}

Show
Shridhar Polas added a comment - We have plan to upgrade to v2.x and to go for paid support with jumpmind. But, for v1.7.x we have already many deployments at customer end and the feasibility to go for paid support in this release is very remote. I had a quick look in the Symmetric code to find how can this issue be fix by doing little change in code. Please share your thoughts on the code change below. In method at line: org.jumpmind.symmetric.db.AbstractDbDialect.getMetaDataFor(AbstractDbDialect.java:278) Current code: public Table getMetaDataFor(String catalogName, String schemaName, String tableName, boolean useCache) { Table retTable = cachedModel.findTable(tableName); if (retTable == null || !useCache) { synchronized (this.getClass()) { try { Table table = findTable(catalogName, schemaName, tableName); if (retTable != null) { cachedModel.removeTable(retTable); } if (table != null) { cachedModel.addTable(table); } retTable = table; } catch (RuntimeException ex) { throw ex; } catch (Exception ex) { throw new RuntimeException(ex); } } } return retTable; } Modified code: public Table getMetaDataFor(String catalogName, String schemaName, String tableName, boolean useCache) { Table retTable = null; synchronized (this.getClass()) { retTable = cachedModel.findTable(tableName); if (retTable == null || !useCache) { try { Table table = findTable(catalogName, schemaName, tableName); if (retTable != null) { cachedModel.removeTable(retTable); } if (table != null) { cachedModel.addTable(table); } retTable = table; } catch (RuntimeException ex) { throw ex; } catch (Exception ex) { throw new RuntimeException(ex); } } } return retTable; }

People

  • Assignee:
    Chris Henson
    Reporter:
    Shridhar Polas
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: