Maven Surefire

Fix classloader separation of Test NG

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0 (2.2 plugin)
  • Fix Version/s: None
  • Component/s: TestNG support
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently, all of the test classes go into the surefire classloader (as before) so that TestNG can find them.

Using the context classloader might be the key to avoiding this.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kenney Westerhof added a comment -

I think this is fixed by my commit in revision 441092 (see SUREFIRE-54).

The solution is to have 2 classloaders; one with the tests, and another one with surefire + testing framework,
that has the tests-classloader as a parent.

Close?

Show
Kenney Westerhof added a comment - I think this is fixed by my commit in revision 441092 (see SUREFIRE-54 ). The solution is to have 2 classloaders; one with the tests, and another one with surefire + testing framework, that has the tests-classloader as a parent. Close?
Hide
Permalink
Brett Porter added a comment -

I think so, but I'm confused (it is early). In junit, we have to use reflection to call out to the test classes from surefire because of the separation of classloaders. Does this solution rely on the ability of testng to use a different classloader, and so by moving testng into the surefire classloader, the tests can be entirely separated?

Show
Brett Porter added a comment - I think so, but I'm confused (it is early). In junit, we have to use reflection to call out to the test classes from surefire because of the separation of classloaders. Does this solution rely on the ability of testng to use a different classloader, and so by moving testng into the surefire classloader, the tests can be entirely separated?
Hide
Permalink
Dan Fabulich added a comment -

I think this issue is minor; so long as you can fork TestNG and so long as TestNG works in the integration tests, this issue can't cause a serious bug.

Show
Dan Fabulich added a comment - I think this issue is minor; so long as you can fork TestNG and so long as TestNG works in the integration tests, this issue can't cause a serious bug.
Hide
Permalink
Kristian Rosenvold added a comment -

I'm closing this issue because as I understand it, it is fixed. There is separation and has been for quite a long time. Feel free to supplement further details if I'm misunderstanding something here.

Show
Kristian Rosenvold added a comment - I'm closing this issue because as I understand it, it is fixed. There is separation and has been for quite a long time. Feel free to supplement further details if I'm misunderstanding something here.

People

  • Assignee:
    Unassigned
    Reporter:
    Brett Porter
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: