Maven Surefire

Parallel junit does not run in parallel when a Suite is used at the top level

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.6, 2.7, 2.8, 2.9, 2.10
  • Fix Version/s: Backlog
  • Component/s: Junit 4.7+ (parallel) support
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Using the test project at maven-surefire/surefire-integration-tests/src/test/resources/junit47-parallel-with-suite one can see that the actual tests do not get run in parallel. This is due to the project running a top-level suite.

I have researched this a little bit, and it seems like this does not even work with regular JUnit (even without our special runners), so the problem may be theirs.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-747 Parallel method execution skips Tests

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jonatan Jönsson added a comment -

Related to this issue is the fact that org.apache.maven.surefire.common.junit4.JUnit4TestChecker#isValidJUnit4Test does not check for suite() methods returning junit.framework.Test (for example https://github.com/Softhouse/jargo/blob/master/jargo/src/test/java/se/softhouse/common/collections/CharacterTrieGuavaTest.java).

I noticed this for my project https://github.com/Softhouse/jargo when I stared to use <parallel>methods</parallel>. You can observe the drop in number of tests at https://jontejj.ci.cloudbees.com/job/jargo/ build #8 and #9.

Show
Jonatan Jönsson added a comment - Related to this issue is the fact that org.apache.maven.surefire.common.junit4.JUnit4TestChecker#isValidJUnit4Test does not check for suite() methods returning junit.framework.Test (for example https://github.com/Softhouse/jargo/blob/master/jargo/src/test/java/se/softhouse/common/collections/CharacterTrieGuavaTest.java ). I noticed this for my project https://github.com/Softhouse/jargo when I stared to use <parallel>methods</parallel>. You can observe the drop in number of tests at https://jontejj.ci.cloudbees.com/job/jargo/ build #8 and #9.
Hide
Permalink
Jonatan Jönsson added a comment -

It's amusing how many isJUNITTest implementations I've seen. It seems to me that JUnit has not done a very good job at making it easy to gather test cases.

Show
Jonatan Jönsson added a comment - It's amusing how many isJUNITTest implementations I've seen. It seems to me that JUnit has not done a very good job at making it easy to gather test cases.
Hide
Permalink
Kristian Rosenvold added a comment -

This might be because you disregard the JUnit3 test checker that does this test ?

Show
Kristian Rosenvold added a comment - This might be because you disregard the JUnit3 test checker that does this test ?
Hide
Permalink
Jonatan Jönsson added a comment -

Aah, I see. I looked a bit deeper but came up empty. If I get the time I'll try to debug it.

Show
Jonatan Jönsson added a comment - Aah, I see. I looked a bit deeper but came up empty. If I get the time I'll try to debug it.

People

  • Assignee:
    Unassigned
    Reporter:
    Kristian Rosenvold
Vote (2)
Watch (5)

Dates

  • Created:
    Updated: