Maven Surefire

Surefire is not isolated from itself

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.4.1, 2.4.2, 2.4.3, 2.5, 2.6, 2.7, 2.7.1, 2.7.2
  • Fix Version/s: 2.8
  • Component/s: classloading
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

The current classloader structure in surefire does not isolate surefire from changes to surefire in itself. This means an interface change in most private interfaces and classes can break the build of surefire itself.

This is due to the classloader structure systemclassloader<-testclassloader<-providerclassloader, where a modified surefire immediately becomes effective by being loaded in testclassloader.

This issue will be fixed by making the following structure:

systemclassloader<-testframeworkclassloader<-testclassloader
systemclassloader<-testframeworkclassloader<-surefireclassloader

Pardon the ascii graphics but it seems like jira does not allow me to draw systemclassloader<-testframeworkclassloader as one common root

  1. Text File
    stage2.patch
    27/Feb/11 9:36 AM
    4 kB
    Kristian Rosenvold

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kristian Rosenvold added a comment -

Fixed in r1071421

Please note that the "api" modules and the "booter" module will have to stay backward compatible with the version of surefire that is running the tests. This is a significant improvement since most implementation classes also had to stay backward compatible before this change.

The core of the change is in ClasspathConfiguration, the rest is just cleaning up classpaths and stuff.

Show
Kristian Rosenvold added a comment - Fixed in r1071421 Please note that the "api" modules and the "booter" module will have to stay backward compatible with the version of surefire that is running the tests. This is a significant improvement since most implementation classes also had to stay backward compatible before this change. The core of the change is in ClasspathConfiguration, the rest is just cleaning up classpaths and stuff.
Hide
Permalink
Kristian Rosenvold added a comment -

The format of the properties files is also pretty constrained when it comes to that.

Show
Kristian Rosenvold added a comment - The format of the properties files is also pretty constrained when it comes to that.
Hide
Permalink
Kristian Rosenvold added a comment -

Reverted commit and reopened because it broke the build on windows

Show
Kristian Rosenvold added a comment - Reverted commit and reopened because it broke the build on windows
Hide
Permalink
Kristian Rosenvold added a comment - - edited

Added "shade" based solution in r1075071.

Please note that this will not be effective until after we have released a version with this patch in it,
at which time we can apply this subsequent patch, stage2.patch. Make sure the version numbers (in shaderfire pom.xml) file are correct when applying this patch. I just add this patch to JIRA in case I get run over by a truck

"shadedVersion" in root pom should be the version of surefire you will be building with, and should be N-1.

Show
Kristian Rosenvold added a comment - - edited Added "shade" based solution in r1075071. Please note that this will not be effective until after we have released a version with this patch in it, at which time we can apply this subsequent patch, stage2.patch. Make sure the version numbers (in shaderfire pom.xml) file are correct when applying this patch. I just add this patch to JIRA in case I get run over by a truck "shadedVersion" in root pom should be the version of surefire you will be building with, and should be N-1.
Hide
Permalink
Kristian Rosenvold added a comment -

I'm marking this issue as fixed for 2.8, since we can start using it immediately afterwards (on 2.8.1-SNAPSHOT).

Show
Kristian Rosenvold added a comment - I'm marking this issue as fixed for 2.8, since we can start using it immediately afterwards (on 2.8.1-SNAPSHOT).
Hide
Permalink
Kristian Rosenvold added a comment -

And, as can be seen from /src/site/apt/developingSurefire.apt this solution is shade based and not classloader based, giving 100% isolation.

Show
Kristian Rosenvold added a comment - And, as can be seen from /src/site/apt/developingSurefire.apt this solution is shade based and not classloader based, giving 100% isolation.

People

  • Assignee:
    Kristian Rosenvold
    Reporter:
    Kristian Rosenvold
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: