Maven Surefire

Maven Surefire Plugin don't run JUnit tests if TestNG in dependencies

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 2.4.3
  • Fix Version/s: None
  • Component/s: Junit 4.x support
  • Labels:
    None
  • Environment:
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

I have a project with a lot of JUnit test. Recently I've added new
dependency wich have TestNG in it's dependencies. From that moment
Surefire plugins don't run JUnit test anymore. It seems to me that
Surefire tries to find TestNG tests but not find them and don't search
for JUnit tests. Is this behaviour correct and how can i fix this?

I have the following line in log:

-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running TestSuite
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.117
sec

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

Example project in attachments.

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-377 When JUnit and TestNG tests are in same project, only one set gets run

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jim Showalter added a comment -

We have encountered the same problem, but for JUnit with JMockit.

To reproduce the problem:

1) Sync to the tip of https://code.intuit.com/sf/projects/testutils.

2) In Eclipse, set M2_REPO and JDK_HOME so the .classpath works. (The JDK has to be version 1.6.x.)

3) Manually install version 0.989 of JMockit into M2_REPO/jmockit/jmockit/0.989/jmockit-0.989.jar. (I'm sorry this is a manual step, but the only version of JMockit in the java.net repo is 0.991, and it has the problem we're grappling with.)

4) In the TestUtils directory, run mvn clean install. You will see that 6 tests run with 0 failures and 0 errors.

5) Change the pom.xml dependency on JMockit to:

<dependency>
<groupId>mockit</groupId>
<artifactId>jmockit</artifactId>
<version>0.991</version>
<scope>test</scope>
</dependency>

6) Change the pom.xml javaagent entry to <argLine>-javaagent:"$

{settings.localRepository}

/mockit/jmockit/0.991/jmockit-0.991.jar"</argLine>.

7) Rerun mvn clean install. You will see that 0 tests run with 0 failures and 0 errors. That's the problem--we can't get the tests to run at all when using version 0.991, and there is no other version in the repo.

Removing the javaagent entry has no effect (our understanding is that it should be possible to remove javaagent entirely and still have JMockit initialize correctly).

ErrorCodeUtilsTest is the only test that uses JMockit, so even if JMockit isn't initializing, it seems as if the other five tests should run.

The tests run in Eclipse even if we change the .classpath entry for JMockit to <classpathentry kind="var" path="M2_REPO/mockit/jmockit/0.991/jmockit-0.991.jar"/>.

Show
Jim Showalter added a comment - We have encountered the same problem, but for JUnit with JMockit. To reproduce the problem: 1) Sync to the tip of https://code.intuit.com/sf/projects/testutils . 2) In Eclipse, set M2_REPO and JDK_HOME so the .classpath works. (The JDK has to be version 1.6.x.) 3) Manually install version 0.989 of JMockit into M2_REPO/jmockit/jmockit/0.989/jmockit-0.989.jar. (I'm sorry this is a manual step, but the only version of JMockit in the java.net repo is 0.991, and it has the problem we're grappling with.) 4) In the TestUtils directory, run mvn clean install. You will see that 6 tests run with 0 failures and 0 errors. 5) Change the pom.xml dependency on JMockit to: <dependency> <groupId>mockit</groupId> <artifactId>jmockit</artifactId> <version>0.991</version> <scope>test</scope> </dependency> 6) Change the pom.xml javaagent entry to <argLine>-javaagent:"$ {settings.localRepository} /mockit/jmockit/0.991/jmockit-0.991.jar"</argLine>. 7) Rerun mvn clean install. You will see that 0 tests run with 0 failures and 0 errors. That's the problem--we can't get the tests to run at all when using version 0.991, and there is no other version in the repo. Removing the javaagent entry has no effect (our understanding is that it should be possible to remove javaagent entirely and still have JMockit initialize correctly). ErrorCodeUtilsTest is the only test that uses JMockit, so even if JMockit isn't initializing, it seems as if the other five tests should run. The tests run in Eclipse even if we change the .classpath entry for JMockit to <classpathentry kind="var" path="M2_REPO/mockit/jmockit/0.991/jmockit-0.991.jar"/>.
Hide
Permalink
Jim Showalter added a comment -

The problem can be fixed for JMockit by upgrading to 0.992, or by adding an exclude to the pom:

<exclusions>
<exclusion>
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
</exclusion>
</exclusions>

In 0.992, all internal JMockit dependencies are marked optional, which causes maven to not transitively add them to the client project.

Should the surefire plugin be adding transitive internal dependencies to the classpath? This could cause problems not just for unit testing.

Show
Jim Showalter added a comment - The problem can be fixed for JMockit by upgrading to 0.992, or by adding an exclude to the pom: <exclusions> <exclusion> <groupId>org.testng</groupId> <artifactId>testng</artifactId> </exclusion> </exclusions> In 0.992, all internal JMockit dependencies are marked optional, which causes maven to not transitively add them to the client project. Should the surefire plugin be adding transitive internal dependencies to the classpath? This could cause problems not just for unit testing.
Hide
Permalink
Carlos Sanchez added a comment -

See SUREFIRE-377

Show
Carlos Sanchez added a comment - See SUREFIRE-377

People

  • Assignee:
    Unassigned
    Reporter:
    Bulat Nigmatullin
Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: