Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.4
-
Component/s: JUnit 3.x support
-
Labels:None
-
Complexity:Intermediate
-
Testcase included:yes
-
Number of attachments :
Description
Surefire (or possibly Xpp3Dom?) should check for invalid characters in JUnit output and escape or mask them to ensure valid XML reports. This applies to all characters outside the allowed range defined in the XML spec (http://www.w3.org/TR/REC-xml/#NT-Char).
I have a JUnit test case that uses assertEquals on strings. In some situations, the string to compare against the reference may be completely garbled and contain things such as null characters, which then show up in the assertion failure message ("expected X but was Y") and consequently in the XML reports.
Here's a simple test case to trigger the problem:
public class InvalidCharactersTest extends TestCase {
public void testStrings() {
String expected = "abc";
String actual = "abc" + '\u0000';
assertEquals(expected, actual);
}
}
The resulting Surefire XML report contains the null character as is and is therefore not valid XML. Running the Surefire Reports plugin then fails with a parsing error.
I am having the same problem with invalid characters. However the invalid character is not in the same exact location for me. I'm getting an invalid character in the "java.library.path" property in the my surefire junit reports.
I will attach the junit report for you to see (line 28:385-388). Also attached is my pom.xml that i used to run test and generate the report.
I'm running on Win2003 server using java 1.5_07, maven 2.0.7 and ant 1.6.5