Attached is an updated patch for junit 4.7. The revised patch also has no dependencies to any external libraries.

Who are the original authors in the dual licensed pieces of code and where did it come from?

I am. I made it dual licensed to be compatible with the junit license. If this is a problem I can change it - I hope The project is located at http://github.com/krosenvold/configurable-parallel-computer

It doesn't have to be, but ideally it would all have the "licensed to Apache..." header they all share. Since it is your own work you can certainly do that. Would you mind resubmitting?

I would like some other changes and clarification:

• instead of "junitcore" is this basically a "junit 4.7+" feature? I got a bit confused by the terminology
• the version parsing seems unusual - can we use a range instead ("[4.7,)")
• can you remove the .orig files from the patch?
• what is the purpose of the separated directory scanner?

Let me know if you need any more info on these.

Yes to all. Will resubmit tomorrow.

The purpose of the separated directory scanner was really just to get it unit-testable as an individual piece. I suppose I couldn't resist the urge to make things more unit-testable, since they're both faster and easier to write. There is also a unit-test for that separate piece of code. At that point I guess It was a bit irresponsible of me not to replace usage in the other plugins too, but I suppose I realized I was getting a bit carried away. The api-contract of the separated scanner is also slightly cleaner than the original.

I can take this both ways (revert to old-style or change the other plugins), what do you think ?

that's fine, I couldn't see a big change so just checking whether it was meant to do something I couldn't see

This is version 3 of the patch (surefirev3.patch). Includes all requested changes.

I will try to submit a subsequent patch to change the other providers to use the external scanner, but this patch is totally self-contained.

It turns out I had done "the right" thing and extracted all the directory scanning to the separate class, so this is effectively in use by all the providers (it was done in the base class for the providers and I extracted it to get more precise test coverage and re-use for the junit 4.7 provider)

Since I'm not totally fluent in the maven internals, you may also want to just check the methods isJunit40to46 and isJunit47Compatible in the revised patch, just in case there's a better way to do it.

v4 also includes what I hope is the appropriate license headers in all files.

Also note that after I artifactid & name of the provider to surefire-junit47 I had to run mvn -N install within the surefire-providers folder and the root folder to get things to compile (assuming you have compiled the previous version within the same checkout)

hi there,

Will the patch be accepted? This new feature looks very interesting.

thanks,
Igor

Please apply this patch (or similar) and let me run my unit tests in half the time

targetting for 2.5

r895651.

This issue was created when JUnit 4.7 was current. The latest version is now 4.8.1.

The patch I supplied uses "any" version of surefire >= 4.7. 4.8 is also recommended, since it contains 2 concurrency patches I submitted to junit. Hopefully, 4.8.1 will find its way to a maven repo soon.