Maven Surefire

ManifestJarWriter should use java.util.jar.Manifest

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.4.2
  • Component/s: process forking
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

ManifestJarWriter manages writing the manifest by hand, including wrapping lines, etc. etc. This code was copied from plexus-archiver when we stopped depending on plexus-archiver.

But AFAIK there's no reason to do that by hand; java.util.jar.Manifest can take care of all of that for us. Still, it's creepy that they did all of that work, so maybe there was a good reason for it...?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Fabulich added a comment -

Notably, I find that the difference between the two is that java.util.jar.Manifest creates a manifest with TWO final newlines; ManifestJarWriter as-is currently creates a manifest with just ONE final newline.

Show
Dan Fabulich added a comment - Notably, I find that the difference between the two is that java.util.jar.Manifest creates a manifest with TWO final newlines; ManifestJarWriter as-is currently creates a manifest with just ONE final newline.
Hide
Permalink
Benjamin Bentmann added a comment -

so maybe there was a good reason for it...?

The old story, where is documentation when one needs it ?

java.util.jar.Manifest creates a manifest with TWO final newlines

Which is in conformance with the Manifiest Specification given the case, that the manifest contains no "individual-sections".

Show
Benjamin Bentmann added a comment - so maybe there was a good reason for it...? The old story, where is documentation when one needs it ? java.util.jar.Manifest creates a manifest with TWO final newlines Which is in conformance with the Manifiest Specification given the case, that the manifest contains no "individual-sections".
Hide
Permalink
Dan Fabulich added a comment -

Fixed in revision 619732, because some users reported getting "Failed to load Main-Class manifest attribute" errors until they extracted the manifest, re-processed it and re-packed it.

http://www.nabble.com/-ANN--Maven-Surefire-Plugin-2.4.1-for-Maven-2-Released-td15307389s177.html

Show
Dan Fabulich added a comment - Fixed in revision 619732, because some users reported getting "Failed to load Main-Class manifest attribute" errors until they extracted the manifest, re-processed it and re-packed it. http://www.nabble.com/-ANN--Maven-Surefire-Plugin-2.4.1-for-Maven-2-Released-td15307389s177.html

People

  • Assignee:
    Unassigned
    Reporter:
    Dan Fabulich
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: