Maven Surefire

In multi-module projects, all tests are run for each module in the module tree

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.4.2
  • Component/s: Maven Surefire Report Plugin
  • Labels:
    None
  • Environment:
    Maven 2.0.8, Linux
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

In a multi-module project, since version 2.4, all tests of all modules are run once for each module. This is very bad with many modules & many tests. Attached is a sample project which contains a parent module and two child modules. Each of the child modules contains one JUnit test. mvn clean site runs each test three times (once for the parent and once for each of the two submodules). When changing the surefire-report-plugin to version 2.3, each test is run only once, as it is supposed to

Issue Links

This issue relates to:
MJAVADOC-171 Modules in multi-module projects are "built" too often Critical Reopened
This issue is related to:
MNG-2184 Possible problem with @aggregator and forked lifecycles Blocker Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Fabulich added a comment -

Thanks for filing this bug; I noticed it too but thought it was just SUREFIRE-257 (which is really a bug in core). But I'm able to reproduce your findings that this wasn't a problem in 2.3, so I'll happily take a crack at it.

Show
Dan Fabulich added a comment - Thanks for filing this bug; I noticed it too but thought it was just SUREFIRE-257 (which is really a bug in core). But I'm able to reproduce your findings that this wasn't a problem in 2.3, so I'll happily take a crack at it.
Hide
Permalink
Dan Fabulich added a comment -

This is happening because I added @aggregator to surefire-report in order to fix SUREFIRE-268. I didn't really know what I was doing there, and I'm really not clear on why this causes the problem, but removing the line seems to help. I'll need to do more research to make sure this is safe.

Show
Dan Fabulich added a comment - This is happening because I added @aggregator to surefire-report in order to fix SUREFIRE-268. I didn't really know what I was doing there, and I'm really not clear on why this causes the problem, but removing the line seems to help. I'll need to do more research to make sure this is safe.
Hide
Permalink
Stefan Seidel added a comment -

Thanks for investigating, Dan. I don't know much about maven plugin dev, but I suspected something like that. Would you agree that this is a serious flaw in maven core? I mean, would it ever make sense to execute a plugin in that way only because it has that @aggregator annotation? I think the same issue (with @aggregator) could be the cause for MJAVADOC-171. I just don't know enough to report this more general bug, but maybe you or someone from the team could?

Show
Stefan Seidel added a comment - Thanks for investigating, Dan. I don't know much about maven plugin dev, but I suspected something like that. Would you agree that this is a serious flaw in maven core? I mean, would it ever make sense to execute a plugin in that way only because it has that @aggregator annotation? I think the same issue (with @aggregator) could be the cause for MJAVADOC-171. I just don't know enough to report this more general bug, but maybe you or someone from the team could?
Hide
Permalink
Dan Fabulich added a comment -

I stripped off @aggregator in revision 619233; that seems to fix your problem.

I'm still not entirely certain I understood this problem; here's a link to the mailing list discussion on this topic:

http://www.nabble.com/%40aggregator-mojo-annotation-td15302246s177.html

Show
Dan Fabulich added a comment - I stripped off @aggregator in revision 619233; that seems to fix your problem. I'm still not entirely certain I understood this problem; here's a link to the mailing list discussion on this topic: http://www.nabble.com/%40aggregator-mojo-annotation-td15302246s177.html
Hide
Permalink
Luc Willems added a comment -

Hello all ,

i'm currently using 2.4.2 version of the plugin but still seeing builds of ALL modules.
i have a complex multi module project with 3 levels of if grandParent -> parent -> child relations.
i'm using Continuum build server and use

mvn clean site-deploy

as goals to run.

i'm not using the report-only options.

Show
Luc Willems added a comment - Hello all , i'm currently using 2.4.2 version of the plugin but still seeing builds of ALL modules. i have a complex multi module project with 3 levels of if grandParent -> parent -> child relations. i'm using Continuum build server and use mvn clean site-deploy as goals to run. i'm not using the report-only options.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.