Maven Surefire

Add integration test to check class path order

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.4.1
  • Component/s: None
  • Labels:
    None
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

The attached integration test checks some ordering constraints on the class path for testing:

  • test-classes should come before main-classes
  • main-classes should come before dependencies

It might not catch all bad cases but currently there seems to be nothing that prevents regression of MNG-3118 or SUREFIRE-61 and this test at least tells you that Surefire-2.3 is broken.

In concern of quality assurance, I would also like to mention that MNG-2365 has an unapplied patch that provides a unit test for MNG-3118.

Attachments

  1. Text File
    classpath-order-it.patch
    21/Jan/08 5:24 PM
    8 kB
    Benjamin Bentmann
  2. Text File
    classpath-order-it.patch
    11/Jan/08 11:08 AM
    14 kB
    Benjamin Bentmann

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment -

Fixed IT patch, contained duplicate contents.

Show
Benjamin Bentmann added a comment - Fixed IT patch, contained duplicate contents.
Hide
Permalink
Dan Fabulich added a comment -

I don't know if we can/should apply this in Surefire, since we use the Surefire integration tests to verify compatibility with old versions of Maven. Maybe the test should be applied in core-integration-testing?

Show
Dan Fabulich added a comment - I don't know if we can/should apply this in Surefire, since we use the Surefire integration tests to verify compatibility with old versions of Maven. Maybe the test should be applied in core-integration-testing?
Hide
Permalink
Benjamin Bentmann added a comment -

Another option might be to guard the test by an if-condition that checks for a newer Maven version similar to a JUnit assumption.

Show
Benjamin Bentmann added a comment - Another option might be to guard the test by an if-condition that checks for a newer Maven version similar to a JUnit assumption.
Hide
Permalink
Dan Fabulich added a comment -

Submitted revision 615427.

Show
Dan Fabulich added a comment - Submitted revision 615427.

People

Vote (2)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.