jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven Surefire
  • SUREFIRE-30

Wrong classpath separator

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.5.2 (2.1.2 plugin), 1.5.3 (2.1.3 plugin)
  • Fix Version/s: 1.5.3 (2.1.3 plugin), 2.0 (2.2 plugin)
  • Component/s: None
  • Labels:
    None
  • Environment:
    Only Windows
  • Complexity:
    Intermediate
  • Testcase included:
    yes

Description

In SurefireBooter when use fork mode elements of classpath are separated by colon. This works on Linux but not on Windows. I sugest to use semicolon.

private static ClassLoader createForkingClassLoader( String basedir )
throws Exception

{ Properties p = loadProperties( basedir, CLASSLOADER_PROPERTIES ); String cp = p.getProperty( "classpath" ); boolean childDelegation = "true".equals( p.getProperty( "childDelegation", "false" ) ); List urls = Arrays.asList( cp.split( ";" ) ); // was List urls = Arrays.asList( cp.split( ":" ) ); return createClassLoader( urls, childDelegation ); }

and

private void getForkArgs( String batteryConfig )
throws Exception
{
.....
else

{ if ( cp.length() == 0 ) cp = url; else cp += ";" + url; // was cp += ":" + url; }
  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    SurefireBooter.patch
    31/Jan/06 5:28 AM
    0.7 kB
    Marcin Cetnarski

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-34 Using security manager in a fork mode causes an AccessControlException

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-36 SurefireBooter's use of colon ":" character for delimeting classpath results in drive letter to be parsed as a seperate classpath entry

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-200 Surefire forkMode not working on windows [patch attached]

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-100 environmentVariables does not work with windows

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Marcin Cetnarski added a comment - 31/Jan/06 5:28 AM

Attached patch.

Show
Marcin Cetnarski added a comment - 31/Jan/06 5:28 AM Attached patch.
Hide
Permalink
Grzegorz Slowikowski added a comment - 08/Mar/06 6:03 AM

System.getProperty("path.separator") should be used

Show
Grzegorz Slowikowski added a comment - 08/Mar/06 6:03 AM System.getProperty("path.separator") should be used
Hide
Permalink
Walco van Loon added a comment - 08/Mar/06 2:34 PM

Why not use

java.io.File.pathSeparator

for this purpose?

Show
Walco van Loon added a comment - 08/Mar/06 2:34 PM Why not use java.io.File.pathSeparator for this purpose?
Hide
Permalink
Brett Porter added a comment - 08/Mar/06 5:05 PM

that's what I used in the 2.0 version. As you can see, it is already marked fixed.

Show
Brett Porter added a comment - 08/Mar/06 5:05 PM that's what I used in the 2.0 version. As you can see, it is already marked fixed.
Hide
Permalink
Grzegorz Slowikowski added a comment - 09/Mar/06 4:02 AM

Brett

I don't understand what are you writing about. 2.0 version of what? This error is in surefire-booter.
Current version is 1.5.2, next will be 1.5.3 (trunk has 1.5.3-SNAPSHOT). Check the sources, nothing
has been fixed.

Show
Grzegorz Slowikowski added a comment - 09/Mar/06 4:02 AM Brett I don't understand what are you writing about. 2.0 version of what? This error is in surefire-booter. Current version is 1.5.2, next will be 1.5.3 (trunk has 1.5.3-SNAPSHOT). Check the sources, nothing has been fixed.
Hide
Permalink
Grzegorz Slowikowski added a comment - 09/Mar/06 4:15 AM

ok, I see, version 2.0-SNAPSHOT is in "surefire-testng" branch.

Show
Grzegorz Slowikowski added a comment - 09/Mar/06 4:15 AM ok, I see, version 2.0-SNAPSHOT is in "surefire-testng" branch.
Hide
Permalink
Brett Porter added a comment - 09/Mar/06 5:41 AM

yes, the dev list has recently voted to make that the new trunk

Show
Brett Porter added a comment - 09/Mar/06 5:41 AM yes, the dev list has recently voted to make that the new trunk
Hide
Permalink
Carlos Sanchez added a comment - 15/Mar/06 11:49 PM

Reopening to fix in 1.5.3

Show
Carlos Sanchez added a comment - 15/Mar/06 11:49 PM Reopening to fix in 1.5.3
Hide
Permalink
Carlos Sanchez added a comment - 15/Mar/06 11:51 PM

Applied patch in trunk

Show
Carlos Sanchez added a comment - 15/Mar/06 11:51 PM Applied patch in trunk

People

  • Assignee:
    Carlos Sanchez
    Reporter:
    Marcin Cetnarski
Vote (1)
Watch (1)

Dates

  • Created:
    27/Jan/06 2:56 AM
    Updated:
    24/Mar/06 5:23 PM
    Resolved:
    16/Mar/06 5:09 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.