jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven Surefire
  • SUREFIRE-264

XRef links do not work with aggregated reports on windows

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0 Report Plugin
  • Fix Version/s: 2.4.3
  • Component/s: Maven Surefire Report Plugin
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

When generating aggregated reports with the jxr-plugin, the xref links cannot be generated correctly on windows.

This is mainly due to the fact that the outputDirectory is a java.lang.String property in stead of a java.io.File property. This makes the propert os dependant. The expression with this property is ${project.build.directory}/site. On windows this should be ${project.build.directory}\site. It might even be beter to change it to ${project.reporting.outputDirectory}. See the checkstyle plugin for reference.

When working with aggregated jxr-reports, the xrefLocation (which IS a java.io.File property) should preferable be ${project.build.directory}/site/../xref-test, since this is the relative publish location of the reports. Being a java.lang.String property, this will resolve to something like c:[path to build directory]\target\site\..\xref-test. In the SurefireReportMojo.determineXrefLocation the absolute path of this file property is compared to the outputDirectory which is a java.lang.String it will probably be set to c:[path to build directory]\target/site (n.b. forward slash in stead of backward slash), which will lead to an empty relative path, where ../xref-test would be expected.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    outputDirectoryIsFile.patch
    27/Nov/06 1:45 AM
    3 kB
    Maarten Winkels

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. SUREFIRE-259 Calculation of relative path to xref is wrong

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Maarten Winkels added a comment - 27/Nov/06 1:45 AM

This patch turns the outputDirectory into a java.io.File. Tests are updated.

Show
Maarten Winkels added a comment - 27/Nov/06 1:45 AM This patch turns the outputDirectory into a java.io.File. Tests are updated.
Hide
Permalink
Benjamin Bentmann added a comment - 19/Jan/08 8:44 AM

See also Common Bugs why changing the parameter type of outputDirectory to java.io.File is a more than advisable.

Show
Benjamin Bentmann added a comment - 19/Jan/08 8:44 AM See also Common Bugs why changing the parameter type of outputDirectory to java.io.File is a more than advisable.
Hide
Permalink
Herve Boutemy added a comment - 08/Mar/08 3:31 PM

patch applied in r635090

thanks

Show
Herve Boutemy added a comment - 08/Mar/08 3:31 PM patch applied in r635090 thanks

People

  • Assignee:
    Herve Boutemy
    Reporter:
    Maarten Winkels
Vote (2)
Watch (0)

Dates

  • Created:
    27/Nov/06 1:11 AM
    Updated:
    03/May/08 1:48 AM
    Resolved:
    08/Mar/08 3:31 PM

Time Tracking

Estimated:
1h
Original Estimate - 1 hour
Remaining:
1h
Remaining Estimate - 1 hour
Logged:
Not Specified
Time Spent - Not Specified
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.