Maven Surefire

Detail display doesn't work if there are tests with the same name

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0 Report Plugin
  • Fix Version/s: 2.7.2
  • Component/s: Maven Surefire Report Plugin
  • Labels:
    None
  • Number of attachments :
    0

Description

toggleDisplay uses only the name of the test method for identifying the tests, it should use the full class name+method name

Activity

Ascending order - Click to sort in descending order
Carlos Sanchez made changes -
Field Original Value New Value
Comment [ This patch should make it work but it does not.

Index: src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
===================================================================
--- src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (revision 452343)
+++ src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (working copy)
@@ -407,10 +407,10 @@
 
                             sink.rawText( " <div class=\"detailToggle\" style=\"display:inline\">" );
 
- sink.link( "javascript:toggleDisplay('" + testCase.getName() + "');" );
+ sink.link( "javascript:toggleDisplay('" + testCase.getFullName() + "');" );
 
- sink.rawText( "<span style=\"display: inline;\" " + "id=\"" + testCase.getName() +
- "off\">+</span><span id=\"" + testCase.getName() + "on\" " +
+ sink.rawText( "<span style=\"display: inline;\" " + "id=\"" + testCase.getFullName() +
+ "off\">+</span><span id=\"" + testCase.getFullName() + "on\" " +
                                 "style=\"display: none;\">-</span> " );
                             sink.text( "[ Detail ]" );
                             sink.link_();
]
Hide
Permalink
Carlos Sanchez added a comment -

This patch should make it work but it does not.

Index: src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
===================================================================
— src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (revision 452343)
+++ src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (working copy)
@@ -407,10 +407,10 @@
 
                             sink.rawText( "  <div class=\"detailToggle\" style=\"display:inline\">" );
 
-                            sink.link( "javascript:toggleDisplay('" + testCase.getName() + "');" );
+                            sink.link( "javascript:toggleDisplay('" + testCase.getFullName() + "');" );
 
-                            sink.rawText( "<span style=\"display: inline;\" " + "id=\"" + testCase.getName() +
-                                "off\">+</span><span id=\"" + testCase.getName() + "on\" " +
+                            sink.rawText( "<span style=\"display: inline;\" " + "id=\"" + testCase.getFullName() +
+                                "off\">+</span><span id=\"" + testCase.getFullName() + "on\" " +
                                 "style=\"display: none;\">-</span> " );
                             sink.text( "[ Detail ]" );
                             sink.link_();
Show
Carlos Sanchez added a comment - This patch should make it work but it does not. Index: src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java =================================================================== — src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (revision 452343) +++ src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (working copy) @@ -407,10 +407,10 @@ sink.rawText( " <div class=\" detailToggle\ " style=\" display:inline\ ">" ); - sink.link( "javascript:toggleDisplay('" + testCase.getName() + "');" ); + sink.link( "javascript:toggleDisplay('" + testCase.getFullName() + "');" ); - sink.rawText( "<span style=\" display: inline;\ " " + "id=\" " + testCase.getName() + - "off\" >+</span><span id=\ "" + testCase.getName() + " on\ " " + + sink.rawText( "<span style=\" display: inline;\ " " + "id=\" " + testCase.getFullName() + + "off\" >+</span><span id=\ "" + testCase.getFullName() + " on\ " " + "style=\" display: none;\ ">-</span> " ); sink.text( "[ Detail ]" ); sink.link_();
Brett Porter made changes -
Project Maven 2.x Surefire report Plugin [ 11222 ] Maven Surefire [ 10541 ]
Affects Version/s 2.0 Report Plugin [ 12481 ]
Key MSUREFIREREP-33 SUREFIRE-260
Brett Porter made changes -
Component/s report plugin [ 12564 ]
Brett Porter made changes -
Affects Version/s 2.0 Report Plugin [ 13171 ]
Brett Porter made changes -
Fix Version/s 2.x [ 13647 ]
Hide
Permalink
Anil Philip added a comment -

This was opened almost 3 years ago - does anyone have a workaround? If so, can you please share it?

Show
Anil Philip added a comment - This was opened almost 3 years ago - does anyone have a workaround? If so, can you please share it?
Hide
Permalink
Kristian Rosenvold added a comment -

Fixed in r1061306

Show
Kristian Rosenvold added a comment - Fixed in r1061306
Kristian Rosenvold made changes -
Status Open [ 1 ] Closed [ 6 ]
Assignee Kristian Rosenvold [ krosenvold ]
Fix Version/s 2.7.2 [ 17030 ]
Resolution Fixed [ 1 ]
Kristian Rosenvold made changes -
Fix Version/s Backlog [ 13647 ]

People

  • Assignee:
    Kristian Rosenvold
    Reporter:
    Carlos Sanchez
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: