Maven Surefire

default excludes prevents inner class test cases

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.4 (2.0 plugin)
  • Fix Version/s: 1.5.2 (2.1.2 plugin)
  • Component/s: None
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    2

Description

some people use inner classes for junit tests since they have access to private variables in the unit tests.

for my particular case we have all unit tests called Foo$TEST

in the DirectoryBattery there was a default excludes that was always getting added to exclude inner classes...so the patch attached moves this default exclusion to the listing of default excluders in the maven-surefire-plugin and removed the forced exclusion.

Issue Links

This issue is related to:
SUREFIRE-66 JUnitBattery dies when TestSuite has an anonymous inner class Major Closed
SUREFIRE-44 Inner class inclusion too powerful Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
chisisi added a comment -

oh, and I had the assumption that the maven-surefire-plugin is the only thing using surefire....if it isn't I can adjust accordingly

Show
chisisi added a comment - oh, and I had the assumption that the maven-surefire-plugin is the only thing using surefire....if it isn't I can adjust accordingly
Hide
Permalink
Jason van Zyl added a comment -

Sorry Jesse, I didn't apply these before I added the forking code. Do you think you could take a peek and see if things still apply and I will push them in asap.

Show
Jason van Zyl added a comment - Sorry Jesse, I didn't apply these before I added the forking code. Do you think you could take a peek and see if things still apply and I will push them in asap.
Hide
Permalink
Carlos Sanchez added a comment -

I've moved the exclusion from surefire to surefire-plugin, nothing done about the includeProjectClassesBattery option.
Probably is better to close this issue and open another in the surefire plugin about that

Show
Carlos Sanchez added a comment - I've moved the exclusion from surefire to surefire-plugin, nothing done about the includeProjectClassesBattery option. Probably is better to close this issue and open another in the surefire plugin about that

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.